[test] Avoid potential NULL pointer dereference in addrman_tests.cpp #9554

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:avoid-null-pointer-dereference-in-addrman_tests changing 1 files +1 −1

practicalswift commented at 7:19 PM on January 14, 2017: contributor

No description provided.
[test] Avoid potential NULL pointer dereference in addrman_tests.cpp afab9f47f6
luke-jr commented at 7:23 PM on January 14, 2017: member

utACK
MarcoFalke commented at 11:15 PM on January 14, 2017: member

This is already checked 5 lines above, no?

On Sat, Jan 14, 2017 at 8:24 PM, Luke Dashjr notifications@github.com wrote:

utACK

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9554#issuecomment-272646726, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmvxtkG4NnowReyNHaiyK_rBxyGSJMks5rSSDTgaJpZM4LjtxM .
practicalswift commented at 11:32 PM on January 14, 2017: contributor
@MarcoFalke BOOST_CHECK(info1, …) (as opposed to BOOST_REQUIRE(info1, …)) won't stop the execution and ...
```
if (info2)
      BOOST_CHECK(info2->ToString() == info1->ToString());		
```
... will be run regardless of the code path taken here ...
```
if (info1)
    BOOST_CHECK(info1->ToString() == "250.1.2.1:8333");
```
... right? :-)
fanquake added the label Tests on Jan 15, 2017
MarcoFalke commented at 1:10 PM on January 15, 2017: member

ACK afab9f47f619120f22e5d586d417c71551f8d000
paveljanik commented at 5:47 PM on January 15, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/commit/afab9f47f619120f22e5d586d417c71551f8d000
MarcoFalke merged this on Jan 22, 2017
MarcoFalke closed this on Jan 22, 2017
MarcoFalke referenced this in commit 0b96abc35f on Jan 22, 2017
codablock referenced this in commit ee566ae540 on Jan 19, 2018
codablock referenced this in commit 05ab5e1ca3 on Jan 20, 2018
codablock referenced this in commit cd04ccd2d9 on Jan 21, 2018
andvgal referenced this in commit 3793837763 on Jan 6, 2019
CryptoCentric referenced this in commit b8dc21bacc on Feb 27, 2019
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels