qt: Use nPowTargetSpacing constant #9588

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1701-qtParams changing 4 files +10 −6

MarcoFalke commented at 7:52 PM on January 19, 2017: member

No description provided.
qt: Use nPowTargetSpacing constant fa4d47814f
MarcoFalke added the label GUI on Jan 19, 2017
MarcoFalke added the label Refactoring on Jan 19, 2017
MarcoFalke added the label Priority Low on Jan 19, 2017
jonasschnelli commented at 7:53 PM on January 19, 2017: contributor

Thanks for the quick cleanup! utACK fa4d47814f298523aeb9a6658cc74fc46d316e33
in src/qt/modaloverlay.h:None in fa4d47814f
```
   8 | @@ -9,7 +9,7 @@
   9 |  #include <QWidget>
  10 |  
  11 |  //! The required delta of headers to the estimated number of available headers until we show the IBD progress
  12 | -static const int REQ_HEADER_HEIGHT_DELTA_SYNC = 24;
  13 | +static constexpr int HEADER_HEIGHT_DELTA_SYNC = 24;
```
jtimon commented at 7:57 PM on January 19, 2017:

No big deal since it's just one more line diff, but out of curiosity, why rename the constant?

MarcoFalke commented at 8:01 PM on January 19, 2017:

It is not like the number represents a required delta, it is basically a more or less arbitrarily chosen delta.

luke-jr commented at 11:18 PM on January 20, 2017:

Fix comment?

MarcoFalke commented at 1:57 AM on January 25, 2017:

Maybe Assume we are syncing headers, should the estimated number of missing headers be larger than that number?
jtimon commented at 8:01 PM on January 19, 2017: contributor

ACK fa4d478
morcos commented at 7:55 PM on January 20, 2017: member

ACK fa4d478
jonasschnelli merged this on Jan 24, 2017
jonasschnelli closed this on Jan 24, 2017
jonasschnelli referenced this in commit 50864529b6 on Jan 24, 2017
MarcoFalke deleted the branch on Jan 25, 2017
codablock referenced this in commit 180db51a6e on Sep 9, 2017
codablock referenced this in commit c90944ecf4 on Sep 11, 2017
UdjinM6 referenced this in commit 91d99fcd3f on Sep 11, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels