Improve readability by removing redundant casts to same type #9590

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:remove-redundant-casts changing 10 files +24 −24

practicalswift commented at 9:26 PM on January 19, 2017: contributor

Same-binaries check:

$ ../bitcoin-maintainer-tools/build-for-compare.py 6d1a4569ef7b73e40f77c830b26c7e1dbdc7410a 82274c02ed2d82537dc55f008a29edb1bc09bbc4
[…]
>>> [do_build] Copying object files...
>>> [do_build] Performing basic analysis pass...
>>> [do_build] Use these commands to compare results:
>>> [do_build] $ sha256sum /tmp/compare/*.stripped
>>> [do_build] $ git diff -W --word-diff /tmp/compare/6d1a4569ef7b73e40f77c830b26c7e1dbdc7410a /tmp/compare/82274c02ed2d82537dc55f008a29edb1bc09bbc4

$ sha256sum /tmp/compare/*.stripped
342c2ed0e60b60990a58cbf5845b256a4f9e3baff9db074baba5e34a620a60ea  /tmp/compare/bitcoind.6d1a4569ef7b73e40f77c830b26c7e1dbdc7410a.stripped
342c2ed0e60b60990a58cbf5845b256a4f9e3baff9db074baba5e34a620a60ea  /tmp/compare/bitcoind.82274c02ed2d82537dc55f008a29edb1bc09bbc4.stripped

$ git diff -W --word-diff /tmp/compare/6d1a4569ef7b73e40f77c830b26c7e1dbdc7410a /tmp/compare/82274c02ed2d82537dc55f008a29edb1bc09bbc4

$

Remove redundant casts. 6d1a4569ef
fanquake added the label Refactoring on Jan 20, 2017
dcousens approved
paveljanik commented at 6:47 AM on January 20, 2017: contributor

Same is not the same on all archs. NACK
practicalswift closed this on Jan 20, 2017
practicalswift commented at 10:10 AM on January 20, 2017: contributor

@paveljanik Thanks! New PR opened fixes the portability issues :-)
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels