Bugfix: RPC/Mining: GBT should return 1 MB sizelimit before segwit activates #9619

1. 
   luke-jr commented at 11:42 PM on January 23, 2017: member

   Not sure how I missed this when fixing the sigoplimit... Better late than never - maybe.

2. jonasschnelli added the label Mining on Jan 24, 2017
3. jonasschnelli added the label RPC/REST/ZMQ on Jan 24, 2017
4. jonasschnelli approved
5. 
   jonasschnelli commented at 8:04 AM on January 24, 2017: contributor

   utACK 8b19cc83bb05c80c391cb1968c5ae5300f193267

6. 
   jtimon commented at 2:20 PM on January 24, 2017: contributor

   utACK 8b19cc8

7. 
   TheBlueMatt commented at 12:18 AM on January 26, 2017: member

   Can you add this to the existing test-cases? Looks like it should be easy.

8. 
   laanwj commented at 12:25 PM on January 26, 2017: member

   utACK https://github.com/bitcoin/bitcoin/commit/8b19cc83bb05c80c391cb1968c5ae5300f193267, agree that a testcase would be superb.

9. 
   sipa commented at 5:04 PM on January 26, 2017: member

   utACK

10. Bugfix: RPC/Mining: GBT should return 1 MB sizelimit before segwit activates 9fc7f0bce9
11. luke-jr force-pushed on Feb 2, 2017
12. 
    luke-jr commented at 8:10 PM on February 2, 2017: member

    Rebased and added tests.

13. 
    MarcoFalke commented at 9:54 PM on February 2, 2017: member

    	Testing detection of non-standard P2WSH witness
    Assertion failed: not(b'bad-txns-vout-negative' == b'bad-witness-nonstandard')
    
      File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/qa/rpc-tests/test_framework/test_framework.py", line 145, in main
        self.run_test()
      File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/qa/rpc-tests/p2p-segwit.py", line 2028, in run_test
        self.test_non_standard_witness()
      File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/qa/rpc-tests/p2p-segwit.py", line 1905, in test_non_standard_witness
        self.std_node.test_transaction_acceptance(p2wsh_txs[0], True, False, b'bad-witness-nonstandard')
      File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/qa/rpc-tests/p2p-segwit.py", line 160, in test_transaction_acceptance
        assert_equal(self.last_reject.reason, reason)
      File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/qa/rpc-tests/test_framework/util.py", line 529, in assert_equal
        raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
    

14. 
    luke-jr commented at 10:45 PM on February 2, 2017: member

    I don't see how that's possible...

15. QA: Test GBT size/weight limit values 279f944e8d
16. luke-jr force-pushed on Feb 16, 2017
17. 
    jtimon commented at 7:20 PM on February 16, 2017: contributor

    re-utACK 279f944

18. 
    sipa commented at 7:43 PM on February 16, 2017: member

    utACK for 0.14

19. 
    luke-jr commented at 8:02 PM on February 16, 2017: member

    ( @MarcoFalke Re-run of Travis didn't have the same issue, so I guess p2p-segwit was/is flakey, and that failure was unrelated to this PR.)

20. MarcoFalke added this to the milestone 0.14.0 on Feb 18, 2017
21. laanwj merged this on Feb 20, 2017
22. laanwj closed this on Feb 20, 2017

    ---

23. laanwj referenced this in commit aa791e2911 on Feb 20, 2017
24. laanwj referenced this in commit 6552729f38 on Feb 20, 2017
25. laanwj referenced this in commit 861cb0c83d on Feb 20, 2017
26. MarcoFalke locked this on Sep 8, 2021

Milestone
0.14.0