Based on #9634.
I remembered why I wrote that to begin with - I was trying to merge signatures from untrusted parties and realized they could cause a DoS by crashing my bitcoind.
This silently skips trying to merge signatures from inputs which do not exist from transactions provided to signrawtransaction, instead of hitting an assert.
84+ for i, inp in enumerate(inputs):
85+ assert_equal(decodedRawTx["vin"][i]["txid"], inp["txid"])
86+ assert_equal(decodedRawTx["vin"][i]["vout"], inp["vout"])
87+
88+ # Make sure decoderawtransaction throws if there is extra data
89+ try:
This silently skips trying to merge signatures from inputs which
do not exist from transactions provided to signrawtransaction,
instead of hitting an assert.
53+ rawTxUnsigned = self.nodes[0].signrawtransaction(rawTx + dummyTxInconsistent, inputs)
54+
55+ assert 'complete' in rawTxUnsigned
56+ assert_equal(rawTxUnsigned['complete'], False)
57+
58+ # Check that signrawtransaction properly merges unsigned and signed txn, even with garbate in the middle
Apologies - post merge question/comment. The new code in DecodeHexTx adds this check for witness transactions not having junk bytes:
0 if (!ssData.empty())
1 return false;
12 lines above is a check for non-witness transactions not having junk bytes:
0 if (ssData.eof()) {
1 return true;
I’m pretty sure that ssData.eof() and ssData.empty() will both be false if there are junk bytes remaining in the CDataStream.
Any reason why you’ve used a different function call? It’s a bit confusing for someone reading the code for the first time.