Fix super-unlikely race introduced in 236618061a445d2cb11e72 #9671

1. 
   TheBlueMatt commented at 6:55 pm on February 2, 2017: member

   Once the CNode has been added to vNodes, it is possible that it is disconnected+deleted in the socket handler thread. However, after that we now call InitializeNode, which accesses the pnode.

   helgrind managed to tickle this case (somehow), but I suspect it requires in immensely braindead scheduler.

2. Fix super-unlikely race introduced in 236618061a445d2cb11e72

   Once the CNode has been added to vNodes, it is possible that it is
   disconnected+deleted in the socket handler thread. However, after
   that we now call InitializeNode, which accesses the pnode.
   
   helgrind managed to tickle this case (somehow), but I suspect it
   requires in immensely braindead scheduler.

   885cfdd217
3. MarcoFalke added this to the milestone 0.14.0 on Feb 2, 2017
4. MarcoFalke added the label P2P on Feb 2, 2017
5. dcousens approved
6. 
   sipa commented at 0:13 am on February 4, 2017: member

   ACK 885cfdd2179a2aae733d0690f5a2ef23d181768e, seems to run fine with -fsanitizes.
7. 
   MarcoFalke commented at 1:13 am on February 4, 2017: member

   utACK 885cfdd2179a2aae733d0690f5a2ef23d181768e
8. laanwj merged this on Feb 4, 2017
9. laanwj closed this on Feb 4, 2017

   ---

10. laanwj referenced this in commit 7821db30e1 on Feb 4, 2017
11. codablock referenced this in commit 2cdafa0ca2 on Jan 21, 2018
12. andvgal referenced this in commit 6ee2ada9af on Jan 6, 2019
13. CryptoCentric referenced this in commit df87cd4e79 on Feb 27, 2019
14. random-zebra referenced this in commit a45e827c60 on Dec 2, 2020
15. MarcoFalke locked this on Sep 8, 2021

Contributors
TheBlueMatt dcousens sipa MarcoFalke

Labels
P2P

Milestone
0.14.0