Qt/Intro: Various fixes #9718

pull luke-jr wants to merge 3 commits into bitcoin:master from luke-jr:intro_fixes changing 1 files +8 −3

luke-jr commented at 4:22 AM on February 8, 2017: member

No description provided.
fanquake added the label GUI on Feb 8, 2017
MarcoFalke commented at 12:28 PM on February 8, 2017: member

ACK on bumping the minimum, as this is part of the release process https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#release-process

Would be great if someone could prepare a pull for all those bumps, so it could be done prior to the branch off.

Not sure if the other changes should go into 0.14.
laanwj commented at 1:37 PM on February 8, 2017: member

At least the changes that change translation messages cannot go into 0.14.
luke-jr force-pushed on Feb 8, 2017
luke-jr force-pushed on Feb 8, 2017
luke-jr commented at 4:31 PM on February 8, 2017: member

Stripped out the translation-touching stuff for now. I think this is good for 0.14.
fanquake added this to the milestone 0.14.0 on Feb 8, 2017
paveljanik commented at 4:49 PM on February 8, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/9718/commits/5bb2a5ee0b4ec05722ce21afd65ba18240e7fbd1
in src/qt/intro.cpp:None in 5bb2a5ee0b outdated
```
  22 | @@ -23,7 +23,7 @@
  23 |  
  24 |  static const uint64_t GB_BYTES = 1000000000LL;
  25 |  /* Minimum free space (in GB) needed for data directory */
  26 | -static const uint64_t BLOCK_CHAIN_SIZE = 80;
  27 | +static const uint64_t BLOCK_CHAIN_SIZE = 102;
```
TheBlueMatt commented at 4:58 PM on February 8, 2017:

This seems low.

118G /mnt/bitcoin/blocks

TheBlueMatt commented at 5:06 PM on February 8, 2017:

Of which only

9.4G /mnt/bitcoin/blocks/index

(-txindex).

luke-jr commented at 5:36 PM on February 8, 2017:

We still store stale blocks forever (but those won't be downloaded in IBD).

TheBlueMatt commented at 6:07 PM on February 8, 2017:

This is on a node which started sync last week, so it shouldnt have many stale blocks.
MarcoFalke commented at 5:58 PM on February 8, 2017: member

BLOCK_CHAIN_SIZE is meant to include some buffer, taking into account when the next bump of this constant is planned. Otherwise it would already be outdated when the software is released. I think you can just round up to the next full 10 GB or something.
Qt/Intro: Update block chain size c8cee26100
Bugfix: Qt/Intro: Chain state needs to be stored even with the full blockchain 93ffba7163
luke-jr force-pushed on Feb 8, 2017
luke-jr commented at 6:53 PM on February 8, 2017: member

Okay, bumped it to 120.
Bugfix: Qt/Intro: Pruned nodes never require *more* space a9baa6d742
sipa commented at 9:26 PM on February 8, 2017: member

utACK a9baa6d742c0425af4fb048cbd85707143227e84
achow101 commented at 9:29 PM on February 8, 2017: member

utACK a9baa6d742c0425af4fb048cbd85707143227e84
TheBlueMatt commented at 9:32 PM on February 8, 2017: member

I would hesitate to call this a bugfix that needs to happen last-hour for 0.14, as it seems rather inconsequential, but utACK a9baa6d742c0425af4fb048cbd85707143227e84.
paveljanik commented at 9:37 PM on February 8, 2017: contributor

reACK https://github.com/bitcoin/bitcoin/commit/a9baa6d742c0425af4fb048cbd85707143227e84
sipa commented at 9:37 PM on February 8, 2017: member

Agree it's mostly an improvement, but we should get the blockchain size estimate update in.
MarcoFalke commented at 10:32 PM on February 8, 2017: member

utACK a9baa6d
laanwj merged this on Feb 9, 2017
laanwj closed this on Feb 9, 2017
laanwj referenced this in commit 36f9d3ae6d on Feb 9, 2017
codablock referenced this in commit 6d1436487d on Jan 19, 2018
codablock referenced this in commit f1f4e25d60 on Jan 23, 2018
andvgal referenced this in commit b9ad99eac1 on Jan 6, 2019
CryptoCentric referenced this in commit a213a34101 on Feb 27, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Milestone
0.14.0

Linked (view graph)

#9724 Qt/Intro: Add explanation of IBD process