Remove fallbacks for boost_filesystem < v3 #9727

1. 
   laanwj commented at 8:22 am on February 9, 2017: member

   Minimum boost version was bumped to 1.47.0 in #8920, which means the configure step won’t even pass with older boost.

   This version has boost filesystem v3, which means the (crappy) fallbacks for older versions can go.

2. laanwj added the label Refactoring on Feb 9, 2017
3. 
   fanquake commented at 8:27 am on February 9, 2017: member

   Concept ACK, I’d be planning on starting some of this. As you may have noticed I have some lists of possible changes in #8875.
4. 
   laanwj commented at 9:47 am on February 9, 2017: member

   Yup, there’s likely some more fallbacks that could be removed.

   However I think the filesystem filebacks are especially bad. In one case (Qt) the behavior of the fallback is just plain wrong in the case of unicode, the other case looks like fragile, hardly-tested code but is luckily in the tests only.

5. 
   paveljanik commented at 11:17 am on February 9, 2017: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/9727/commits/763ef23ef4cef3456dda9c3a147a7709f308134a
6. Remove fallbacks for boost_filesystem < v3

   Minimum boost version was bumped to 1.47.0 in #8920, which
   means the configure step won't even pass with older boost.
   
   This version has boost filesystem v3, which means the
   (crappy) fallbacks for older versions can go.

   056aba2b4f
7. laanwj force-pushed on Feb 10, 2017
8. 
   laanwj commented at 11:33 am on February 10, 2017: member

   Updated - there as another one in wallet.cpp, which I skipped over because it used BOOST_VERSION instead of BOOST_FILESYSTEM_VERSION as distinguisher.

   That should cover them all - in my post here #8875 (comment) I’ve listed the remaining ones, which all deal with newer versions (and non filesystem).

9. fanquake added this to the "In progress" column in a project

   ---

10. 
    fanquake commented at 12:49 pm on February 16, 2017: member

    utACK 056aba2

    This removes all our uses of BOOST_FILESYSTEM_VERSION. We’re also down to 3 uses of BOOST_VERSION in /src.

11. laanwj merged this on Feb 21, 2017
12. laanwj closed this on Feb 21, 2017

    ---

13. laanwj referenced this in commit 5f0556d032 on Feb 21, 2017
14. 
    sipa commented at 6:48 pm on February 21, 2017: member

    Posthumous utACK.
15. fanquake moved this from the "In progress" to the "Done" column in a project

    ---

16. PastaPastaPasta referenced this in commit 950f8d1523 on Dec 28, 2018
17. PastaPastaPasta referenced this in commit 9513fed444 on Dec 29, 2018
18. PastaPastaPasta referenced this in commit ed8ed9bff4 on Dec 29, 2018
19. UdjinM6 referenced this in commit a49f4123e5 on Jan 3, 2019
20. CryptoCentric referenced this in commit c632f583ae on Jul 11, 2019
21. MarcoFalke locked this on Sep 8, 2021

Contributors
laanwj fanquake paveljanik sipa

Labels
Refactoring