Also decrease default send/receive buffer sizes from 10 to 5 mb as this patch makes it easy for a node to fill both instead of only send.
The largest advantage is not having to read from disk or serialize blocks on getblocks requests.
Also decrease default send/receive buffer sizes from 10 to 5 mb as this patch makes it easy for a node to fill both instead of only send.
The largest advantage is not having to read from disk or serialize blocks on getblocks requests.
Looks like fun stuff to play around with… building now.
Disagree with the minor AddAddress debug change. Once a node is running, these messages are (a) minimal and (b) useful. Better approach is to start separating messages at a much more fine grain, by introducing, e.g. fNetDebug (network-related messages) and fTxDebug (tx/mempool-related messages)
The “don’t disconnect” part of this change worries me.
If an attacker can connect to you 100 times from 100 different IP addresses and then fill up the send buffer on each connection that’s bad.
I suppose they could try to fill up your send buffer minus 1 byte now…
What if a node sends you a good new latest best block while the send buffer to that node is full, and then disconnects?
Probably not a real issue, and I certainly likes this approach more than the earlier hack to cut off the 500 block invs earlier when size exceeds the buffer.
Also decrease default send/receive buffer sizes from 10 to 5 mb
as this patch makes it easy for a node to fill both instead of
only send.
TheBlueMatt
jgarzik
sipa
Diapolo
gavinandresen
Milestone
0.7.0