[Trivial] Remove nonsense #undef foreach #9732

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:removeundefforeach changing 1 files +0 −1

jnewbery commented at 7:11 PM on February 9, 2017: member

This PR removes #undef foreach from txmempool.h. That preprocessor directive was added in 34628a18070064e75b35f28fd6a43d5c23832eb8 (https://github.com/bitcoin/bitcoin/pull/6654) but there doesn't appear to be a #define foreach anywhere in the codebase. The #undef directive doesn't actually do anything.

Remove nonsense #undef foreach

This commit removes a preprocessor #undef for a macro that was never
defined. Should make no difference to compiled code.

467df390f0

fanquake added the label Mempool on Feb 9, 2017
fanquake added the label Refactoring on Feb 9, 2017
MarcoFalke commented at 7:49 PM on February 9, 2017: member

gives same binaries for me ACK 467df39
jtimon commented at 8:05 PM on February 9, 2017: contributor

utACK 467df39
dcousens approved
sipa commented at 6:54 AM on February 10, 2017: member

Obvious ACK.

This was added in #6654, without explanation.
paveljanik commented at 7:45 AM on February 10, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/commit/467df390f0a620859c46e49d0894b0b7f8dc55ad
laanwj commented at 9:00 AM on February 10, 2017: member

but there doesn't appear to be a #define foreach anywhere in the codebase.

IIRC Qt defines this, and there was a conflict with that and some other dependency. But if it's no longer necessary that's great.
fanquake commented at 1:02 PM on February 16, 2017: member

utACK 467df39
laanwj merged this on Feb 28, 2017
laanwj closed this on Feb 28, 2017
laanwj referenced this in commit c322fa472e on Feb 28, 2017
HashUnlimited referenced this in commit ec45f45064 on Feb 27, 2018
PastaPastaPasta referenced this in commit a4e1917507 on Dec 28, 2018
PastaPastaPasta referenced this in commit a78e6cf735 on Dec 29, 2018
PastaPastaPasta referenced this in commit 3749256af3 on Dec 29, 2018
PastaPastaPasta referenced this in commit 9f14076dbc on Dec 31, 2018
PastaPastaPasta referenced this in commit c7237b651a on Jan 2, 2019
PastaPastaPasta referenced this in commit 2610da0204 on Jan 3, 2019
PastaPastaPasta referenced this in commit 8f03662ee1 on Jan 5, 2019
PastaPastaPasta referenced this in commit dc69dbf8f6 on Jan 7, 2019
PastaPastaPasta referenced this in commit 809fc179a1 on Jan 7, 2019
PastaPastaPasta referenced this in commit f51d2e0947 on Jan 23, 2019
PastaPastaPasta referenced this in commit 68ef997707 on Jan 25, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6654 Mempool package tracking