Lack of error checking noticed by @morcos.
Return error when importmulti called with invalid address. #9756
pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/multiaddr changing 2 files +13 −0-
ryanofsky commented at 10:59 PM on February 13, 2017: member
-
9acf25cc01
Return error when importmulti called with invalid address.
Lack of error checking noticed by Alex Morcos <morcos@chaincode.com>
- fanquake added the label RPC/REST/ZMQ on Feb 14, 2017
- fanquake added the label Wallet on Feb 14, 2017
- laanwj added this to the milestone 0.14.0 on Feb 14, 2017
-
laanwj commented at 2:07 PM on February 14, 2017: member
This breaks the importmulti.py testedit: passes after re-kicking travisimportmulti.py: Initializing test directory /tmp/testsw_twapp/630 start_node: bitcoind started, waiting for RPC to come up start_node: RPC successfully started start_node: bitcoind started, waiting for RPC to come up start_node: RPC successfully started Mining blocks... Should import an address Should not import an invalid address JSONRPC error: JSON value is not an integer as expected Stopping nodes Not cleaning up dir /tmp/testsw_twapp/630 From /tmp/testsw_twapp/630/node0/regtest/debug.log : 2017-02-13 23:22:34 -
morcos commented at 5:52 PM on February 14, 2017: member
utACK 9acf25c
just needs trivial rebase (works on master now that
"timestamp" : "now"is valid) -
laanwj commented at 2:32 PM on February 15, 2017: member
- laanwj merged this on Feb 15, 2017
- laanwj closed this on Feb 15, 2017
- laanwj referenced this in commit 7a93af8340 on Feb 15, 2017
- codablock referenced this in commit 31535d517c on Jan 19, 2018
- codablock referenced this in commit da8808fba0 on Jan 23, 2018
- andvgal referenced this in commit 99c34779c2 on Jan 6, 2019
- CryptoCentric referenced this in commit 9c73027286 on Feb 27, 2019
- DrahtBot locked this on Sep 8, 2021