Return error when importmulti called with invalid address. #9756

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/multiaddr changing 2 files +13 −0
  1. ryanofsky commented at 10:59 PM on February 13, 2017: member

    Lack of error checking noticed by @morcos.

  2. Return error when importmulti called with invalid address.
    Lack of error checking noticed by Alex Morcos <morcos@chaincode.com>
    9acf25cc01
  3. fanquake added the label RPC/REST/ZMQ on Feb 14, 2017
  4. fanquake added the label Wallet on Feb 14, 2017
  5. laanwj added this to the milestone 0.14.0 on Feb 14, 2017
  6. laanwj commented at 2:07 PM on February 14, 2017: member

    This breaks the importmulti.py test edit: passes after re-kicking travis

    importmulti.py:
    Initializing test directory /tmp/testsw_twapp/630
    start_node: bitcoind started, waiting for RPC to come up
    start_node: RPC successfully started
    start_node: bitcoind started, waiting for RPC to come up
    start_node: RPC successfully started
    Mining blocks...
    Should import an address
    Should not import an invalid address
    JSONRPC error: JSON value is not an integer as expected
    Stopping nodes
    Not cleaning up dir /tmp/testsw_twapp/630
    From /tmp/testsw_twapp/630/node0/regtest/debug.log :
    2017-02-13 23:22:34 
    
  7. morcos commented at 5:52 PM on February 14, 2017: member

    utACK 9acf25c

    just needs trivial rebase (works on master now that "timestamp" : "now" is valid)

  8. laanwj merged this on Feb 15, 2017
  9. laanwj closed this on Feb 15, 2017

  10. laanwj referenced this in commit 7a93af8340 on Feb 15, 2017
  11. codablock referenced this in commit 31535d517c on Jan 19, 2018
  12. codablock referenced this in commit da8808fba0 on Jan 23, 2018
  13. andvgal referenced this in commit 99c34779c2 on Jan 6, 2019
  14. CryptoCentric referenced this in commit 9c73027286 on Feb 27, 2019
  15. DrahtBot locked this on Sep 8, 2021

Milestone
0.14.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me