Selectively suppress deprecation warnings #9758

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2017/02/deprac_warns changing 2 files +6 −0

jonasschnelli commented at 10:10 AM on February 14, 2017: contributor

These warnings are really annoying (~serval hundreds on my Mac/clang) and throwing in CXXFLAGS=-Wdeprecated-declarations seems not ideal.

This PR suppresses deprecation warnings for some Mac relevant code (launch on startup) as well as for the protobuf parts.
jonasschnelli added the label MacOSX on Feb 14, 2017
gmaxwell commented at 10:15 AM on February 14, 2017: contributor

Concept ACK. Thanks for doing this.
in src/qt/guiutil.cpp:None in cf6d2c2835 outdated
```
 825 | @@ -824,6 +826,7 @@ bool SetStartOnSystemStartup(bool fAutoStart)
 826 |      }
 827 |      return true;
 828 |  }
 829 | +#pragma GCC diagnostic push
```
paveljanik commented at 10:17 AM on February 14, 2017:

push?

jonasschnelli commented at 10:22 AM on February 14, 2017:

Pop! Will change! Thanks.
laanwj commented at 11:31 AM on February 14, 2017: member

Cannot test this, but looks like the right way to go at it.
Selectively suppress deprecation warnings 4b6ccccc16
jonasschnelli force-pushed on Feb 14, 2017
jonasschnelli commented at 12:51 PM on February 14, 2017: contributor

Fixed the push/pop mixup (thanks @paveljanik!).
paveljanik commented at 2:54 PM on February 14, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/9758/commits/4b6ccccc16b615c01939678e589f8e09cfc15d70
laanwj merged this on Feb 15, 2017
laanwj closed this on Feb 15, 2017
laanwj referenced this in commit 476cc47da0 on Feb 15, 2017
theuni commented at 8:40 PM on February 15, 2017: member

post-merge utACK.
codablock referenced this in commit a7e0eb5f09 on Jan 19, 2018
codablock referenced this in commit 136d8606c8 on Jan 23, 2018
HashUnlimited referenced this in commit ccc19ae52a on Feb 27, 2018
andvgal referenced this in commit 3f88cf0e1c on Jan 6, 2019
CryptoCentric referenced this in commit 47434654a6 on Feb 27, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels