Add missing cs_wallet lock that triggers new lock held assertion #9771

1. 
   ryanofsky commented at 10:07 PM on February 15, 2017: member

   A new AssertLockHeld(cs_wallet) call was added in commit a58370e "Dedup nTimeFirstKey update logic" (part of PR #9108).

   The lock held assertion will fail when loading prexisting wallets files from before the #9108 merge that have watch-only keys.

2. Add missing cs_wallet lock that triggers new lock held assertion

   A new AssertLockHeld(cs_wallet) call was added in commit a58370e
   "Dedup nTimeFirstKey update logic" (part of PR #9108).
   
   The lock held assertion will fail when loading prexisting wallets files from
   before the #9108 merge that have watch-only keys.

   07afcd6379
3. 
   ryanofsky commented at 10:08 PM on February 15, 2017: member

   This bug was found by @morcos. It should be tagged for 0.14 because it's a regression caused by #9108.

4. 
   morcos commented at 10:27 PM on February 15, 2017: member

   ACK 0f25026

   seems like it might be better to just lock cs_wallet for the whole function call, but i don't know if there is some reason it wasn't written that way.

5. ryanofsky force-pushed on Feb 15, 2017
6. 
   ryanofsky commented at 10:38 PM on February 15, 2017: member

   I don't see any reason, updated the PR. 0f25026b553771817928ceb96d33d1bab942e18c -> 07afcd6379bb46ace5856f6a47a9188cf9aed2ea (loadlock.0 -> loadlock.1)

7. fanquake added the label Wallet on Feb 16, 2017
8. fanquake added this to the milestone 0.14.0 on Feb 16, 2017
9. 
   laanwj commented at 8:36 AM on February 16, 2017: member

   utACK https://github.com/bitcoin/bitcoin/pull/9771/commits/07afcd6379bb46ace5856f6a47a9188cf9aed2ea

10. laanwj merged this on Feb 16, 2017
11. laanwj closed this on Feb 16, 2017

    ---

12. laanwj referenced this in commit e43a58514d on Feb 16, 2017
13. codablock referenced this in commit e16fd0241a on Jan 19, 2018
14. codablock referenced this in commit bb2c1624c9 on Jan 23, 2018
15. andvgal referenced this in commit 1f5117e758 on Jan 6, 2019
16. CryptoCentric referenced this in commit 2416c6e4bf on Feb 27, 2019
17. LarryRuane referenced this in commit b9d7f27b24 on Feb 24, 2021
18. LarryRuane referenced this in commit 7b4fe98230 on Apr 1, 2021
19. str4d referenced this in commit 4fd7387cef on Apr 1, 2021
20. zkbot referenced this in commit 1b5f17c900 on Apr 1, 2021
21. zkbot referenced this in commit 80e66e7daa on Apr 2, 2021
22. MarcoFalke locked this on Sep 8, 2021

Milestone
0.14.0