Avoid variable length arrays #9785

pull sipa wants to merge 2 commits into bitcoin:master from sipa:constkeysize changing 3 files +2 −4

sipa commented at 7:43 PM on February 17, 2017: member

This removes this warning in some G++ versions:

httprpc.cpp: In function ‘bool HTTPReq_JSONRPC(HTTPRequest*, const string&)’:
httprpc.cpp:150:13: warning: stack protector not protecting local variables: variable length buffer [-Wstack-protector]
 static bool HTTPReq_JSONRPC(HTTPRequest* req, const std::string &)
             ^~~~~~~~~~~~~~~

Make KEY_SIZE a compile-time constant 914fad155d
Move BIP70_MAX_PAYMENTREQUEST_SIZE to header c801c82e25
sipa renamed this:
~~Make KEY_SIZE a compile-time constant~~
Avoid variable length arrays
on Feb 17, 2017
theuni commented at 8:10 PM on February 17, 2017: member

utACK c801c82e253dc4956069b6110f65b43f538dd5a1
luke-jr commented at 8:35 PM on February 17, 2017: member

utACK
laanwj commented at 8:48 PM on February 17, 2017: member

utACK c801c82
laanwj merged this on Feb 17, 2017
laanwj closed this on Feb 17, 2017
laanwj referenced this in commit df42bcdbfe on Feb 17, 2017
gmaxwell commented at 8:49 PM on February 17, 2017: contributor

utACK
laanwj referenced this in commit f873564231 on Feb 17, 2017
laanwj referenced this in commit 973e345f7f on Feb 17, 2017
codablock referenced this in commit 5e596423a4 on Jan 26, 2018
lateminer referenced this in commit d59e623aa9 on Jan 3, 2019
andvgal referenced this in commit dcbbe910e3 on Jan 6, 2019
CryptoCentric referenced this in commit ec1548a5b0 on Feb 27, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors