Fix segfault crash when shutdown the GUI in disablewallet mode #9817

1. 
   jonasschnelli commented at 1:43 pm on February 21, 2017: contributor

   Should fix #9816. Was introduced in #9190.
2. Fix segfault crash when shutdown the GUI in disablewallet mode 312c4f1057
3. jonasschnelli added the label GUI on Feb 21, 2017
4. jonasschnelli added this to the milestone 0.14.0 on Feb 21, 2017
5. 
   ryanofsky commented at 1:59 pm on February 21, 2017: member

   Obvious utACK 312c4f10574ccf6dfe0d4ecb3ce928733d3a1e52.

   Were you planning to add a test? I haven’t looked into qt unit testing, but it is nice when simple bugfixes like this are accompanied by tests to increase meaningful test coverage. (It’s easy to imagine similar bugs with –disablewallet being introduced in the future.)

6. 
   paveljanik commented at 2:09 pm on February 21, 2017: contributor

   ACK https://github.com/bitcoin/bitcoin/commit/312c4f10574ccf6dfe0d4ecb3ce928733d3a1e52

   Is #9746 the same?

7. 
   laanwj commented at 2:12 pm on February 21, 2017: member

   Were you planning to add a test? I haven’t looked into qt unit testing, but it is nice when simple bugfixes like this are accompanied by tests to increase meaningful test coverage. (It’s easy to imagine similar bugs with –disablewallet being introduced in the future.)

   There are unit tests for Qt, but currently nothing that can test window setup/teardown or UI interaction.

8. laanwj merged this on Feb 21, 2017
9. laanwj closed this on Feb 21, 2017

   ---

10. laanwj referenced this in commit 8528d6ac6d on Feb 21, 2017
11. laanwj referenced this in commit 7d75a5a93c on Feb 21, 2017
12. laanwj referenced this in commit c6811c1bd3 on Feb 21, 2017
13. 
    laanwj commented at 2:16 pm on February 21, 2017: member

    Backported to 0.14 as 7d75a5a, 0.13 as c6811c1
14. 
    MarcoFalke commented at 9:21 pm on February 23, 2017: member

    @ryanofsky Were you planning to add a test? I haven’t looked into qt unit testing, but it is nice when simple bugfixes like this are accompanied by tests to increase meaningful test coverage. (It’s easy to imagine similar bugs with –disablewallet being introduced in the future.)

    You can run BITCOIND=bitcoin-qt ./qa/pull-tester/rpc-tests.py for basic sanity checking of the gui.

15. codablock referenced this in commit 0a6f63bb24 on Jan 26, 2018
16. andvgal referenced this in commit ea85461421 on Jan 6, 2019
17. CryptoCentric referenced this in commit 9a0d426890 on Feb 27, 2019
18. DrahtBot locked this on Sep 8, 2021

Contributors
jonasschnelli ryanofsky paveljanik laanwj MarcoFalke

Labels
GUI

Milestone
0.14.0