Simple fix, currently the Window is not shown, if a user opens a bitcoin: link in the browser. This one brings the window to front, if it's minimized or not active.
show Window, when user is clicking bitcoin: link #988
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:URL-Handling changing 1 files +5 −0-
Diapolo commented at 7:21 AM on March 26, 2012: none
-
make sure Window is shown when clicking bitcoin: Links to get user attention 4004b9a40b
-
laanwj commented at 10:05 AM on March 26, 2012: member
Programs that jump to the foreground when they want your attention are terrible.
There are better ways; a blinking icon, a notification, etc. (remember that any js can send bitcoin urls) This is heavily dependent on the window environment so hopefully Qt has a function for it.
-
Diapolo commented at 12:55 PM on March 26, 2012: none
If I click an bitcoin: URL and nothing happens that is simply not good ... what do you expect from clicking a mailto: link? From my side I would like my mail client startet as the foreground application, have the address filled in. How is your preference here?
How differ bitcoin: links from mailto: links? I've never seen a script that spams me with mailto: and opens tons of Thunderbird windows :)?
-
laanwj commented at 1:53 PM on March 26, 2012: member
I just read that windows 7 does the right thing when activatewindow is called: blink the entry on the taskbar. No "focus stealing" is allowed. So this patch is fine.
-
TheBlueMatt commented at 5:55 PM on March 26, 2012: member
ACK for 0.6
- laanwj referenced this in commit e9f9282bde on Mar 26, 2012
- laanwj merged this on Mar 26, 2012
- laanwj closed this on Mar 26, 2012
- coblee referenced this in commit b9a0493564 on Jul 17, 2012
- suprnurd referenced this in commit 8c09a459b1 on Dec 5, 2017
- ptschip referenced this in commit 117114957b on Mar 8, 2018
- Bushstar referenced this in commit fe3c7f9163 on Sep 1, 2019
- lateminer referenced this in commit 15858bdb4a on Oct 30, 2019
- DrahtBot locked this on Sep 8, 2021
Milestone
0.7.0