Add Pieter's old signed commits to revsig-commits #9884

1. 
   TheBlueMatt commented at 1:30 AM on February 28, 2017: member

   Pieter revoked some subkeys, meaning we now have to whitelist them for verify-commits to pass. The purpose of the allow-revsig-commits file is just this - if a key is revoked, for whatever reason, you commit the list of hashes so that we still allow the sig, but only for commits that were known prior to the revocation. Because Pieter revoked those subkeys with "superceded", we could try to check that flag, instead, but I'm not sure if you can re-revoke with a new flag like "compromised" later.

2. Add Pieter's old signed commits to revsig-commits a4b02f4275
3. MarcoFalke added the label Scripts and tools on Feb 28, 2017
4. MarcoFalke added this to the milestone 0.14.1 on Feb 28, 2017
5. laanwj merged this on Feb 28, 2017
6. laanwj closed this on Feb 28, 2017

   ---

7. laanwj referenced this in commit 11049f4fe6 on Feb 28, 2017
8. laanwj referenced this in commit 5e70912234 on Feb 28, 2017
9. 
   MarcoFalke commented at 3:47 PM on February 28, 2017: member

   Even though this is already merged, post merge ACKs are very welcome for this pull.

10. MarcoFalke added this to the milestone 0.14.0 on Feb 28, 2017
11. MarcoFalke removed this from the milestone 0.14.1 on Feb 28, 2017
12. 
    TheBlueMatt commented at 6:06 PM on February 28, 2017: member

    Reviewers may wish to git-show all of the commits listed, ensure they are on the history of current trusted master, and make sure they are, indeed, signed by one of Pieter's now-revoked subkeys.

    Matt

    On 02/28/17 15:47, MarcoFalke wrote:

    Even though this is already merged, post merge ACKs are very welcome for this pull.

    — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9884#issuecomment-283076329, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnoHg5m3ZEzqle1owwM2d4Y40zDOVY6ks5rhEGegaJpZM4MN2o5.

13. 
    MarcoFalke commented at 1:28 PM on March 4, 2017: member

    Post merge utACK a4b02f4. Verified that those commits are in the master branch. Did not verify that they were signed by a revoked key.

14. MarcoFalke locked this on Sep 8, 2021

Contributors

TheBlueMattMarcoFalke

Milestone
0.14.0