AppInitMain: split initialization of Connman into a new function #9897

pull benma wants to merge 1 commits into bitcoin:master from benma:connman changing 1 files +64 −56

benma commented at 7:02 AM on March 1, 2017: none

An effort to reduce the size of AppInitMain().
fanquake added the label Refactoring on Mar 1, 2017
benma force-pushed on Mar 9, 2017
AppInitMain: split initialization of Connman into a new function
An effort to reduce the size of AppInitMain().
259c09d0e7
benma force-pushed on Mar 9, 2017
benma commented at 12:52 PM on March 9, 2017: none

Rebased.
dcousens commented at 2:56 AM on March 10, 2017: contributor

concept ACK
laanwj commented at 7:47 AM on March 10, 2017: member

Ping @theuni (as he wrote the Connman code).
laanwj requested review from theuni on Mar 10, 2017
theuni changes_requested
theuni commented at 9:20 PM on March 10, 2017: member

Mm, I like the consolidation, but this kinda confuses the interface and gets in the way of the clean instantiation. The things currently done before starting connman are actually just config options that haven't been moved in yet.

What I'd much prefer (just hadn't gotten around yet) is to add: CConnman::Options::vWhitelist CConnman::Options::vBinds CConnman::Options::vSeedNodes

I think we can combine the approaches by keeping the creation as-is, and having InitConnman() parse the config options and return a CConnman::Options.
benma commented at 10:09 AM on May 27, 2017: none

@theuni

Thanks, that makes a whole lot of sense. I started the process with vSeedNodes in #10467, and will revisit this PR once the rest of the initialization is cleaned up.
ryanofsky commented at 3:27 PM on June 1, 2017: member

#10496 seems to be the next PR in this progression.
laanwj commented at 4:13 PM on June 5, 2017: member

Needs rebase after #10467 (I guess?)
benma commented at 8:30 PM on November 11, 2017: none

Might revisit with a new PR some day.
benma closed this on Nov 11, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10496 Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options