In the case where you use a copy constructor(no instance in codebase now), Bad Things can happen, including crash.
Disallow copy constructor CReserveKeys #9906
pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:noreservecopy changing 1 files +4 −0-
instagibbs commented at 1:07 AM on March 3, 2017: member
- fanquake added the label Wallet on Mar 3, 2017
-
laanwj commented at 1:57 PM on March 3, 2017: member
- gmaxwell approved
-
gmaxwell commented at 7:38 PM on March 4, 2017: contributor
utACK
-
sipa commented at 7:40 PM on March 4, 2017: member
You probably want to delete assignment operators too, or at least invoke ReturnKey before assigning.
-
Disallow copy of CReserveKeys 188f89c3bb
- instagibbs force-pushed on Mar 6, 2017
-
instagibbs commented at 2:27 PM on March 6, 2017: member
Went ahead and made it non-copyable altogether.
- laanwj merged this on Mar 6, 2017
- laanwj closed this on Mar 6, 2017
- laanwj referenced this in commit 72fb5158b1 on Mar 6, 2017
- PastaPastaPasta referenced this in commit 70c7a577c9 on Dec 30, 2018
- PastaPastaPasta referenced this in commit 59f36b0412 on Dec 31, 2018
- PastaPastaPasta referenced this in commit ef7cf07a9c on Dec 31, 2018
- PastaPastaPasta referenced this in commit f532d4a3bb on Dec 31, 2018
- PastaPastaPasta referenced this in commit b3b0ebf24e on Jan 2, 2019
- PastaPastaPasta referenced this in commit 0b45bbb014 on Jan 2, 2019
- PastaPastaPasta referenced this in commit 96f2fa44e5 on Jan 3, 2019
- PastaPastaPasta referenced this in commit 165c544aa5 on Jan 21, 2019
- PastaPastaPasta referenced this in commit 9fb33d9e0d on Jan 27, 2019
- PastaPastaPasta referenced this in commit 03ec70b154 on Jan 29, 2019
- PastaPastaPasta referenced this in commit 1d0825ea1e on Feb 5, 2019
- PastaPastaPasta referenced this in commit a31b2de7ac on Feb 5, 2019
- random-zebra referenced this in commit 2d50b6e3b9 on Jun 9, 2021
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels