Define 7200 second timestamp window constant #9908

1. 
   ryanofsky commented at 10:32 am on March 3, 2017: member
2. fanquake added the label Tests on Mar 3, 2017
3. MarcoFalke renamed this:
   Define 7200 second timestamp window constant
   tests: Define 7200 second timestamp window constant
   on Mar 3, 2017
4. MarcoFalke renamed this:
   tests: Define 7200 second timestamp window constant
   Define 7200 second timestamp window constant
   on Mar 3, 2017
5. MarcoFalke added the label Refactoring on Mar 3, 2017
6. MarcoFalke removed the label Tests on Mar 3, 2017
7. in src/chain.h: in 3b8d451f63 outdated

   24+ * Timestamp window used as a grace period by code that compares external
   25+ * timestamps (such as timestamps passed to RPCS, or wallet key creation times)
   26+ * to block timestamps. This should be set at least as high as
   27+ * MAX_FUTURE_BLOCK_TIME.
   28+ */
   29+static const int64_t TIMESTAMP_WINDOW = MAX_FUTURE_BLOCK_TIME;
   

   ---

   ---

   

   laanwj commented at 1:09 pm on March 3, 2017:

   Isn’t this a wallet constant?

   ---

   

   ryanofsky commented at 1:46 pm on March 3, 2017:

   Isn’t this a wallet constant?

   No, it’s also used by the pruneblockchain RPC (#9778).

   ---

   

   laanwj commented at 2:14 pm on March 3, 2017:

   OK
8. 
   laanwj commented at 4:34 pm on March 3, 2017: member

   utACK https://github.com/bitcoin/bitcoin/pull/9908/commits/3b8d451f63caa7acd8c64e405f2908ad18abd216
9. Define 7200 second timestamp window constant e57a1fd899
10. in src/chain.h: in 3b8d451f63 outdated

    20+ */
    21+static const int64_t MAX_FUTURE_BLOCK_TIME = 2 * 60 * 60;
    22+
    23+/**
    24+ * Timestamp window used as a grace period by code that compares external
    25+ * timestamps (such as timestamps passed to RPCS, or wallet key creation times)
    

    ---

    ---

    

    paveljanik commented at 6:00 pm on March 3, 2017:

    RPCs?

    ---

    

    ryanofsky commented at 6:45 pm on March 3, 2017:

    Sure, changed in de4134470bac6cb437d8267249f1a99315b117a1
11. ryanofsky force-pushed on Mar 3, 2017
12. 
    ryanofsky commented at 6:54 pm on March 3, 2017: member

    Squashed de4134470bac6cb437d8267249f1a99315b117a1 -> e57a1fd8999800b3fc744d45bb96354cae294032 (pr/timewin.1 -> pr/timewin.2)
13. 
    paveljanik commented at 7:07 pm on March 3, 2017: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/9908/commits/e57a1fd8999800b3fc744d45bb96354cae294032
14. laanwj merged this on Mar 6, 2017
15. laanwj closed this on Mar 6, 2017

    ---

16. laanwj referenced this in commit 5a6af31722 on Mar 6, 2017
17. in src/chain.h:21 in e57a1fd899

    13@@ -14,6 +14,20 @@
    14 
    15 #include <vector>
    16 
    17+/**
    18+ * Maximum amount of time that a block timestamp is allowed to exceed the
    19+ * current network-adjusted time before the block will be accepted.
    20+ */
    21+static const int64_t MAX_FUTURE_BLOCK_TIME = 2 * 60 * 60;
    

    ---

    ---

    

    jtimon commented at 6:48 pm on March 23, 2017:

    This one belongs in consensus/consensus.h

    ---

    

    ryanofsky commented at 7:14 pm on March 23, 2017:

    This one belongs in consensus/consensus.h

    I don’t have an opinion, but when I discussed this with @morcos a while ago, I think he suggested it shouldn’t go there because it isn’t a constant that needs to be exactly the same everywhere to have consensus.

18. codablock referenced this in commit 5901531bc2 on Jan 26, 2018
19. PastaPastaPasta referenced this in commit d1921eff36 on Dec 30, 2018
20. PastaPastaPasta referenced this in commit 6fff6754c4 on Dec 30, 2018
21. PastaPastaPasta referenced this in commit 84626a9506 on Dec 30, 2018
22. PastaPastaPasta referenced this in commit 42677ac915 on Dec 31, 2018
23. PastaPastaPasta referenced this in commit 8f310cac91 on Dec 31, 2018
24. PastaPastaPasta referenced this in commit 0ab1cac862 on Dec 31, 2018
25. PastaPastaPasta referenced this in commit 14955f6ec9 on Dec 31, 2018
26. PastaPastaPasta referenced this in commit b8345b6f9e on Dec 31, 2018
27. PastaPastaPasta referenced this in commit 69fb59141d on Dec 31, 2018
28. PastaPastaPasta referenced this in commit 588b83fc8d on Dec 31, 2018
29. PastaPastaPasta referenced this in commit dcbcfdbf23 on Jan 2, 2019
30. PastaPastaPasta referenced this in commit f2f14e49bc on Jan 2, 2019
31. PastaPastaPasta referenced this in commit 16eea8f7e7 on Jan 2, 2019
32. PastaPastaPasta referenced this in commit b03711f3a9 on Jan 2, 2019
33. PastaPastaPasta referenced this in commit 50504b84f9 on Jan 3, 2019
34. PastaPastaPasta referenced this in commit 03379e3b34 on Jan 3, 2019
35. andvgal referenced this in commit 8e54b7de72 on Jan 6, 2019
36. PastaPastaPasta referenced this in commit 4dcce71c28 on Jan 21, 2019
37. PastaPastaPasta referenced this in commit e0c8383b39 on Jan 21, 2019
38. PastaPastaPasta referenced this in commit 2e88b55090 on Jan 25, 2019
39. PastaPastaPasta referenced this in commit 7aeaa4bf87 on Jan 25, 2019
40. PastaPastaPasta referenced this in commit afdb0a2677 on Jan 25, 2019
41. PastaPastaPasta referenced this in commit c70aa60792 on Jan 25, 2019
42. CryptoCentric referenced this in commit 3a5181a99f on Feb 27, 2019
43. DrahtBot locked this on Sep 8, 2021

Contributors
ryanofsky laanwj paveljanik jtimon

Labels
Refactoring