Fix verify-commits on OSX, update for new bad Tree-SHA512, point travis to different keyservers #9940

pull TheBlueMatt wants to merge 4 commits into bitcoin:master from TheBlueMatt:2017-03-verify-commits-no-recursion changing 3 files +67 −63

TheBlueMatt commented at 5:09 PM on March 7, 2017: member

This should (again) fix all known issues in verify-commits
fanquake added the label Scripts and tools on Mar 7, 2017
in contrib/verify-commits/verify-commits.sh:None in 8e0610b563 outdated
```
  61 |  		export BITCOIN_VERIFY_COMMITS_ALLOW_REVSIG=1
  62 |  	else
  63 |  		export BITCOIN_VERIFY_COMMITS_ALLOW_REVSIG=0
  64 |  	fi
  65 |  
  66 |  	if ! git -c "gpg.program=${DIR}/gpg.sh" verify-commit $1 > /dev/null; then
```
jonasschnelli commented at 8:13 AM on March 9, 2017:

I think $1 shouldn't be here. I think you have to change $1 to $CURRENT_COMMIT?

TheBlueMatt commented at 2:54 PM on March 9, 2017:

Grr, you're right, fixed.
jonasschnelli commented at 8:20 AM on March 9, 2017: contributor

Worked for me after I changed $1 to $CURRENT_COMMIT on L66.
Make verify-commits.sh non-recursive fd5e905e21

Fix travis failing to fetch keys from the sks keyserver pool

Just use the "subset" pool for now, at least none of those are
currently broken, AFAIK.

8ed849fbcd

If GNU sha512sum is missing, try perl shasum in verify-commits efc06c2c46
Update trusted-sha512-root-commit for new bad tree hash df5bae2e7b
TheBlueMatt force-pushed on Mar 9, 2017
jonasschnelli commented at 8:34 PM on March 12, 2017: contributor

Tested ACK df5bae2e7b0ccd2b983f19123b0d4b619ea2e598
laanwj merged this on Mar 13, 2017
laanwj closed this on Mar 13, 2017
laanwj referenced this in commit fa99663bec on Mar 13, 2017
PastaPastaPasta referenced this in commit 87efb0e6c3 on Jan 2, 2019
PastaPastaPasta referenced this in commit fc2279ff34 on Jan 2, 2019
PastaPastaPasta referenced this in commit 480d326971 on Jan 2, 2019
PastaPastaPasta referenced this in commit 1e98838e74 on Jan 3, 2019
PastaPastaPasta referenced this in commit 75f43e3f63 on Jan 21, 2019
PastaPastaPasta referenced this in commit d343220008 on Jan 29, 2019
PastaPastaPasta referenced this in commit ba8a0c1deb on Feb 26, 2019
PastaPastaPasta referenced this in commit c55e019bf7 on Feb 26, 2019
UdjinM6 referenced this in commit 666ec4dfff on Mar 9, 2019
PastaPastaPasta referenced this in commit e498ad50a2 on Mar 10, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels