Fix extended rpc tests broken by #9768 #9972

1. 
   jnewbery commented at 8:23 pm on March 10, 2017: member

   3 of the extended qa tests were broken by #9768. This fixes them:

   • maxblocksinflight failed because there was a call to self.log in TestManager, but TestManager doesn’t have a log attribute. Fixed by passing the log handler from the MaxBlocksInFlight object to the TestManager object
   • pruning failed because the string formatting was broken in the calls to self.log.info. Fixed by fixing the formatting.
   • smartfees failed because a helper function was calling self.log, but didn’t have a log variable. Fixed by making the log object global in that module (my initial fix was to change all the helper functions to methods, but this is less disruptive). @MarcoFalke has proposed a fix for maxblocksinflight in #9971 and @sdaftuar has a fix for smartfees in #9970 . Both of those are fine and I’m happy to go with them as alternatives. This PR collects fixes for all three breaks in one place.
2. 
   TheBlueMatt commented at 8:43 pm on March 10, 2017: member

   smartfees still fails for me with “log is not defined”
3. Fix extended rpc tests broken by 8910b4717e5bb946ee6988f7fe9fd461f53a5935 d055bd69cf
4. jnewbery force-pushed on Mar 10, 2017
5. 
   jnewbery commented at 8:51 pm on March 10, 2017: member

   Should be fixed. Can you try again?
6. 
   sdaftuar commented at 9:33 pm on March 10, 2017: member

   Extended tests all pass for me now. ACK
7. fanquake added the label Tests on Mar 10, 2017
8. 
   MarcoFalke commented at 10:04 pm on March 10, 2017: member

   Thanks and utACK d055bd69cf9f48ecaa8c5c820186c296421f0e16
9. MarcoFalke merged this on Mar 10, 2017
10. MarcoFalke closed this on Mar 10, 2017

    ---

11. MarcoFalke referenced this in commit 21833f9456 on Mar 10, 2017
12. PastaPastaPasta referenced this in commit 087885e9b8 on Jan 2, 2019
13. PastaPastaPasta referenced this in commit e931cc79bd on Jan 2, 2019
14. PastaPastaPasta referenced this in commit ceb59d5dfe on Jan 2, 2019
15. PastaPastaPasta referenced this in commit b47c06edf0 on Jan 3, 2019
16. PastaPastaPasta referenced this in commit 2e7939b6bd on Jan 21, 2019
17. PastaPastaPasta referenced this in commit 2e5d899481 on Jan 29, 2019
18. PastaPastaPasta referenced this in commit 31385edcd8 on Feb 26, 2019
19. PastaPastaPasta referenced this in commit 914bd78770 on Feb 26, 2019
20. UdjinM6 referenced this in commit 82791f3a89 on Mar 9, 2019
21. PastaPastaPasta referenced this in commit d136b6ad5d on Mar 10, 2019
22. DrahtBot locked this on Sep 8, 2021

Contributors
jnewbery TheBlueMatt sdaftuar MarcoFalke

Labels
Tests