Helps to make visible the low bandwidth traffic and high bandwidth (or spikes) concurrently. (Previously the low bandwidth traffic becomes invisible in the presence of spikes).
Old format:
New format:
Old format:
New format:
(clicking on the graph will toggle between the new format and the old format).
Love the idea, the problem with these things is there’s gonna be someone who is annoyed by the behavior change.
When I do things like this, I always maintain the old behavior somehow, so that kind of reaction against gets suppressed more easily.
Love the idea, the problem with these things is there’s gonna be someone who is annoyed by the behavior change.
When I do things like this, I always maintain the old behavior somehow, so that kind of reaction against gets suppressed more easily.
I agree, which is why I’ve now (latest commit) made it toggleable - just click on the graph to switch between the two display options.
Concept ACK.
Love the idea, the problem with these things is there’s gonna be someone who is annoyed by the behavior change. When I do things like this, I always maintain the old behavior somehow, so that kind of reaction against gets suppressed more easily.
I agree, which is why I’ve now (latest commit) made it toggleable - just click on the graph to switch between the two display options.
Obscure, but OK.
63 }
64 path.lineTo(x, YMARGIN + h);
65 }
66 }
67
68+void TrafficGraphWidget::mousePressEvent(QMouseEvent *event)
This isn’t a great UI decision for end users. This functionality is hidden from users. If they discover it, it would be by accident; after having clicked on the Network Traffic widget.
Let’s make this feature more accessible and documented by adding two buttons next to the reset button: one that sets the existing format and another button that enables the new format introduced in this PR.
The fToggle variable here should then be made into a persistent setting.
Additionally, when a longer sampling period has been set with the slider; it can take a minute or longer for the format to switch. There are optimizations that need to be done. I have not investigated this.
@jarolrod What options are available so far for making GUI changes persistent? Regarding the delay when the slider is moved, I fixed that in a later update, and the delay now is no longer than the delay already present when clicking the reset button.
What more obvious way might there be to reveal the Y axis is toggleable? A tooltip on the graph perhaps? I am reluctant to add extra buttons given the slider is already providing many values in so little space, so I do prefer the clicking on the graph to change it. It may be that someone finds it by accident, but then this could be a pleasant surprise that - an “easter egg” feature!
What more obvious way might there be to reveal the Y axis is toggle-able?
Yes, button, of course! Checkbox, radio, all those are good.
A tooltip on the graph perhaps?
Improves from no tooltip, but no, that’s not enough improvement.
I am reluctant to add extra buttons given the slider is already providing many values in so little space, so I do prefer the clicking on the graph to change it.
What? No, that’s an huge slider. An unnecessarily large one. Sliders can be as small as necessary when they are combined with a text-box presenting the slided value. There’s a huge empty space below the legend too. There’s plenty of available space to discard invisible toggles.
It may be that someone finds it by accident, but then this could be a pleasant surprise that - an “easter egg” feature!
No, an easter egg is meant to be fun or charming in some way. Hiding actual feature in the same way like one could do with a true easter egg transgredes the principle of least surprise.
Cheers!
Concept ACK
More useful information “at a glance”.
Adding a label to the highest horizontal line would be useful.
I did consider this, but as it’s not the current functionality, and it would make the highest point on the graph no longer reach the top (as the label would need extra space) I decided against it. Could be done as a separate pull request though.
Adding a label to the highest horizontal line would be useful. @RandyMcMillan #492 also reduces the need for this as now you can point to a point on the graph to get details.
e.g. (displays time in the same format as in the debug,log so also makes it easy to find the corresponding point in the log file).
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
No conflicts as of last run.
@rebroad - added this in PR #539
https://github.com/bitcoin-core/gui/pull/539/commits/10f8e797bcd6d8f8910b7560a6e132d197b5f97b
NOTE: I was careful to preserve commit authorship attribution: 👍🏽 https://github.com/bitcoin-core/gui/pull/539/commits