ghost
commented at 3:45 pm on March 22, 2022:
none
bitcoin-qt throws an error and crashes if incoming connections are disabled in settings. This did not happen in v22.0 but noticed it in RC2 during testing.
Expected behavior
Disable listenonion and launch bitcoin-qt automatically.
No error and bitcoin-qt should start as it happens with v22.0
Actual behavior
To reproduce
Download v22.0, run and disable incoming connections in settings
Restart bitcoin-qt
Download RC2, run and look for errors when incoming connections are disabled
System information
Confirmed the issue on Ubuntu and Windows
unknown added the label
Bug
on Mar 22, 2022
hebasto
commented at 5:11 pm on March 22, 2022:
member
Isn’t an error message self-descriptive?
FWIW, the behavior is not GUI-specific:
0$ ./bin/bitcoind -listen=0 -listenonion=1
1Error: Cannot set -listen=0 together with -listenonion=1
hebasto
commented at 5:20 pm on March 22, 2022:
member
The behavior was changed in bitcoin/bitcoin#20769.
hebasto removed the label
Bug
on Mar 22, 2022
hebasto added the label
Questions and Help
on Mar 22, 2022
hebasto
commented at 5:23 pm on March 22, 2022:
member
vasild
commented at 9:33 am on March 23, 2022:
contributor
To reproduce:
start bitcoin-qt, go to settings -> network and remove the checkbox from “Allow incoming connections”
shut down
start bitcoin-qt - it refuses to start with Error: Cannot set -listen=0 together with -listenonion=1
That “Allow incoming connections” setting is saved in ~/.config/Bitcoin/Bitcoin-Qt.conf under fListen=false.
The problem is that during bitcoin-qt startup, when fListen=false in ~/.config/Bitcoin/Bitcoin-Qt.conf, then:
When InitParameterInteraction() executes, args.GetBoolArg("-listen", DEFAULT_LISTEN) is true (!?), so listenonion’s default value is not flipped from true to false
When AppInitParameterInteraction() executes, args.GetBoolArg("-listen", DEFAULT_LISTEN) is false and listenonion is still with its default value (true), untouched by the user. Thus the error due to the incompatible options.
vasild referenced this in commit
1ce31ff843
on Mar 23, 2022
vasild referenced this in commit
7f90dc26c8
on Mar 23, 2022
This is a metadata mirror of the GitHub repository
bitcoin-core/gui.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-12-22 08:20 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me