make ‘-min’ minimize wallet loading dialog #749

pull furszy wants to merge 1 commits into bitcoin-core:master from furszy:2023_gui_start_minimized changing 5 files +17 −11
  1. furszy commented at 11:43 pm on August 13, 2023: member

    Simple fix for #748.

    When ‘-min’ is enabled, no loading dialog should be presented on screen during startup.

  2. gui: make '-min' minimize wallet loading dialog
    When '-min' is enabled, no loading dialog should
    be presented on screen during startup.
    32db15450a
  3. DrahtBot commented at 11:43 pm on August 13, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. furszy renamed this:
    gui: make '-min' minimize wallet loading dialog
    make '-min' minimize wallet loading dialog
    on Aug 13, 2023
  5. DrahtBot added the label CI failed on Aug 17, 2023
  6. DrahtBot removed the label CI failed on Aug 22, 2023
  7. pablomartin4btc commented at 11:47 pm on August 22, 2023: contributor
    I’ve tested this change. Created several wallets in order to see the “Loading wallet…” dialog for a while. Without your change in master when I run bitcoin-qt -min the dialog is not shown and the app opens as usual. With your change when I run bitcoin-qt -min, the app gets minimized entirely, is that intentional?
  8. furszy commented at 12:26 pm on August 23, 2023: member

    I’ve tested this change. Created several wallets in order to see the “Loading wallet…” dialog for a while. Without your change in master when I run bitcoin-qt -min the dialog is not shown and the app opens as usual. With your change when I run bitcoin-qt -min, the app gets minimized entirely, is that intentional?

    Yes. Thats the -min flag purpose: start the app minimized.

  9. hebasto approved
  10. hebasto commented at 11:21 am on August 31, 2023: member

    ACK 32db15450a9ef2a45de29b3b2ae60491a38edbd6, tested on Debian 11 + XFCE.

    The bug did not reveal itself on my Ubuntu + GNOME.

  11. hebasto merged this on Aug 31, 2023
  12. hebasto closed this on Aug 31, 2023

  13. Frank-GER referenced this in commit a2ec5ec52a on Sep 8, 2023
  14. jonatack commented at 9:41 pm on October 30, 2023: member
    FWIW, a user on #bitcoin IRC mentioned today that this patch wasn’t backported to v25.x.
  15. furszy deleted the branch on Oct 30, 2023
  16. bitcoin-core locked this on Oct 29, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-01 03:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me