Simple fix for #748.
When ‘-min’ is enabled, no loading dialog should be presented on screen during startup.
When '-min' is enabled, no loading dialog should
be presented on screen during startup.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | hebasto |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
bitcoin-qt -min
the dialog is not shown and the app opens as usual.
With your change when I run bitcoin-qt -min
, the app gets minimized entirely, is that intentional?
I’ve tested this change. Created several wallets in order to see the “Loading wallet…” dialog for a while. Without your change in master when I run
bitcoin-qt -min
the dialog is not shown and the app opens as usual. With your change when I runbitcoin-qt -min
, the app gets minimized entirely, is that intentional?
Yes. Thats the -min
flag purpose: start the app minimized.
ACK 32db15450a9ef2a45de29b3b2ae60491a38edbd6, tested on Debian 11 + XFCE.
The bug did not reveal itself on my Ubuntu + GNOME.