Simple fix for #748.
When '-min' is enabled, no loading dialog should be presented on screen during startup.
make '-min' minimize wallet loading dialog #749
pull furszy wants to merge 1 commits into bitcoin-core:master from furszy:2023_gui_start_minimized changing 5 files +17 −11-
furszy commented at 11:43 PM on August 13, 2023: member
-
32db15450a
gui: make '-min' minimize wallet loading dialog
When '-min' is enabled, no loading dialog should be presented on screen during startup.
-
DrahtBot commented at 11:43 PM on August 13, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- furszy renamed this:
gui: make '-min' minimize wallet loading dialog
make '-min' minimize wallet loading dialog
on Aug 13, 2023 - DrahtBot added the label CI failed on Aug 17, 2023
- DrahtBot removed the label CI failed on Aug 22, 2023
-
pablomartin4btc commented at 11:47 PM on August 22, 2023: contributor
I've tested this change. Created several wallets in order to see the "Loading wallet..." dialog for a while. Without your change in master when I run
bitcoin-qt -minthe dialog is not shown and the app opens as usual. With your change when I runbitcoin-qt -min, the app gets minimized entirely, is that intentional? -
furszy commented at 12:26 PM on August 23, 2023: member
I've tested this change. Created several wallets in order to see the "Loading wallet..." dialog for a while. Without your change in master when I run
bitcoin-qt -minthe dialog is not shown and the app opens as usual. With your change when I runbitcoin-qt -min, the app gets minimized entirely, is that intentional?Yes. Thats the
-minflag purpose: start the app minimized. - hebasto approved
-
hebasto commented at 11:21 AM on August 31, 2023: member
ACK 32db15450a9ef2a45de29b3b2ae60491a38edbd6, tested on Debian 11 + XFCE.
The bug did not reveal itself on my Ubuntu + GNOME.
- hebasto merged this on Aug 31, 2023
- hebasto closed this on Aug 31, 2023
- Frank-GER referenced this in commit a2ec5ec52a on Sep 8, 2023
-
jonatack commented at 9:41 PM on October 30, 2023: member
FWIW, a user on #bitcoin IRC mentioned today that this patch wasn't backported to v25.x.
- furszy deleted the branch on Oct 30, 2023
- bitcoin-core locked this on Oct 29, 2024
