Wrong dialog icon for "Wallet to be encrypted" #106

jonasschnelli commented at 10:59 AM on October 23, 2020: contributor

The used icon in the "Wallet to be encrypted" is rather one used for "errors": <img width="618" alt="Bildschirmfoto 2020-10-23 um 12 56 10" src="https://user-images.githubusercontent.com/178464/96995926-48906180-152f-11eb-849c-0c72f890cbef.png">

Ideally there is a non-red icon so people aren't thinking something went wrong.

jonasschnelli added the label Bug on Oct 23, 2020

jonasschnelli commented at 11:03 AM on October 23, 2020: contributor

On the other hand, we might want to use a warning icon to make people actual read the content... so unsure if we should fix this.

MarcoFalke commented at 11:41 AM on October 23, 2020: contributor

I'd say this was intentional

hebasto commented at 1:29 PM on October 23, 2020: member

Hmm, I've got a yellow triangle: Screenshot from 2020-10-23 16-28-56

... and the QMessageBox::warning is used: https://github.com/bitcoin-core/gui/blob/49984b44cfcd3fd0cef16c8ce97197973afc3c04/src/qt/askpassphrasedialog.cpp#L130-L133

jarolrod commented at 11:58 PM on October 30, 2020: member

The red circle is the default icon for QMessageBox::critical, which would make this an interesting quirk. Also, it's entirely possible that what is shown is a QMessageBox::warning with the wrong icon being passed because of your systems GTK cache files. Certain GTK themes can influence what icon actually comes up as Qt >5.7 implemented a feature that uses the system's GTK cache files to load some icons. For example, I can get this white error symbol to come up: encryption-warning-2

To stay consistent, we could just provide our own custom icon via: QMessageBoxName.setIcon(QMessageBox::setIconPixmap(arg))

hebasto commented at 9:57 AM on November 4, 2020: member

@jarolrod

... as Qt >5.7 implemented a feature that uses the system's GTK cache files to load some icons.

Could elaborate?

hebasto added the label Linux on Mar 5, 2021