Currently vQueueNotifications holds transactions of any wallet, but the queue is dispatched on a given wallet and it assumes notifications are of that wallet.
This means that some transactions can be missed if multiple wallets are loaded.
Fix this by having a queue for each wallet.
This is needed because next commit moves vQueueNotifications to
TransactionTablePriv member.
Drop global vQueueNotifications and make one for each wallet.
733@@ -734,7 +734,7 @@ void TransactionTablePriv::ShowProgress(const std::string &title, int nProgress)
734 }
735 for (unsigned int i = 0; i < vQueueNotifications.size(); ++i)
736 {
737- if (vQueueNotifications.size() - i <= 10) {
738+ if (vQueueNotifications.size() == 10 + 1 + i) {
In commit “qt: Enqueue setProcessingQueuedTransactions(false) only once” (5ff42b72e93508dfae41e082bbbc7c7ee4aacf6b)
This is kind of hard to follow, and not 100% sure I understand it. IIUC, calling setProcessingQueuedTransactions with false argument turns on balloons, calling it with true argument turns off balloons.
Previously if the queue size was more than 10, balloons were turned off before looping through transactions. Then for every transaction starting at i >= size-10 (i.e. for the most recent 10 transactions) balloons were turned on before updating each transaction.
Now balloons are turned on at i == size-11 so an extra balloon will be shown. (For example if size is 11, balloons are now turned on at i=0 instead of i=1).
If this is right, I’d make a few suggestions:
+ 1 term which does not seem correct// Re-enable balloons for the most recent 10 transactionsi == size-10 or i + 10 == size instead of size == 10 + i, which seems more obscure. The only variable in the expression is i (everything else is constant) so it’s good to emphasize i writing it at the beginning.
ACK 241434200ec2067673d8522fee4f1228abfd8247, I have reviewed the code and it looks OK, I agree it can be merged.
nit: Could follow our style guide (at least apply clang-format-diff.py) for non-move-only commits?
