unlock encrypted wallet "OK" button bugfix #138

1. 
   mjdietzx commented at 8:22 PM on November 27, 2020: contributor

   When trying to send a transaction from an encrypted wallet, the ask passphrase dialog would not allow the user to click the "OK" button and proceed. Therefore it was impossible to send a transaction through the gui. It was not enabling the "OK" button after the passphrase was entered by the user, because it was using the same form validation logic as the "Change passphrase" flow.

   I reported this in a comment in #136. But then I realized this seems to be a flat out bug.

2. qt: unlock wallet "OK" button bugfix

   When trying to send a transaction from an encrypted wallet, the ask
   passphrase dialog would not allow the user to click the "OK" button
   and proceed. Therefore it was impossible to send a transaction
   through the gui. It was not enabling the "OK" button after the
   passphrase was entered by the user, because it was using the same
   form validation logic as the "Change passphrase" flow.

   8008ef770f
3. 
   mjdietzx commented at 9:15 PM on November 27, 2020: contributor

   This bug was introduced in this commit https://github.com/bitcoin-core/gui/commit/6e950118a31fd6a85026d934fc6adb6255e47e23#diff-6fb84ee9edb2f6effebfefeea02e3548508d2043ea997132a17d9f44505f28d4L223, and it's bc the Decrypt case was removed from the switch statement (which the Unlock case had been falling back to / relying on)

4. MarcoFalke renamed this:
   qt: unlock encrypted wallet "OK" button bugfix
   unlock encrypted wallet "OK" button bugfix
   on Nov 28, 2020
5. 
   MarcoFalke commented at 8:52 AM on November 28, 2020: contributor

   review ACK 8008ef770f3d0b14d03e22371314500373732143

   nice catch!

6. MarcoFalke added this to the milestone 0.22.0 on Nov 28, 2020
7. MarcoFalke added the label Bug on Nov 28, 2020
8. hebasto approved
9. 
   hebasto commented at 9:24 AM on November 28, 2020: member

   ACK 8008ef770f3d0b14d03e22371314500373732143, I have reviewed the code and it looks OK, I agree it can be merged.

   Sorry for introducing this bug :man_facepalming:

10. MarcoFalke merged this on Nov 28, 2020
11. MarcoFalke closed this on Nov 28, 2020

    ---

12. 
    Sjors commented at 12:05 PM on November 28, 2020: member

    It would be good to push the git tags from the main repo to this repo as well, so it's more clear which releases the regression is present in (looks like this one isn't in v0.21).

13. mjdietzx deleted the branch on Nov 28, 2020
14. sidhujag referenced this in commit 0dddb26c8e on Nov 28, 2020
15. Fabcien referenced this in commit 4fc92bdfa7 on Jan 17, 2022
16. bitcoin-core locked this on Feb 15, 2022

Contributors

mjdietzxMarcoFalkehebastoSjors

Milestone
22.0