scripted-diff: rename movie folder to animation #14

pull Bushstar wants to merge 1 commits into bitcoin-core:master from Bushstar:bitcoin-rename-animation changing 40 files +41 −41

Bushstar commented at 3:27 PM on June 29, 2020: contributor

Rename the movies directory and RES_MOVIES make variable to animation and RES_ANIMATION respectively. Movies is a bit of an unexpected term to be found.
Bushstar renamed this:
~~[gui] rename movie folder to animation~~
scripted-diff: rename movie folder to animation
on Jun 29, 2020
hebasto commented at 3:31 PM on June 29, 2020: member
How about:
- src/Makefile.qt.include
- src/qt/bitcoin.qrc
- src/qt/bitcoingui.cpp
?
Bushstar commented at 3:32 PM on June 29, 2020: contributor

@hebasto bear with me! I thought some magic would pick up and apply the script. Will apply now.
Bushstar force-pushed on Jun 29, 2020
Bushstar force-pushed on Jun 29, 2020
Bushstar commented at 3:39 PM on June 29, 2020: contributor

@hebasto now updated to what I believe is correct.
hebasto commented at 3:43 PM on June 29, 2020: member

Just for the record: this was mentioned by @MarcoFalke in https://github.com/bitcoin/bitcoin/pull/19394#issuecomment-651169100:

RES_ANIMATION would be a better name for the spinner, I guess
Sjors commented at 4:32 PM on June 29, 2020: member

Concept ACK, thanks for making this a scripted diff.
Bushstar commented at 5:39 PM on June 29, 2020: contributor

@Sjors thanks.

Still a WIP it seems. Guess the script also needs to rename the folder, will update.
hebasto commented at 5:42 PM on June 29, 2020: member

@Bushstar

Still a WIP it seems. Guess the script also needs to rename the folder, will update.

I think it is OK:

scripted-diff: rename movie folder to animation

-BEGIN VERIFY SCRIPT-
sed -i -e 's/movies/animation/g' `git grep -l "movies"`
sed -i -e 's/RES_MOVIES/RES_ANIMATION/g' `git grep -l "RES_MOVIES"`
git mv src/qt/res/movies/ src/qt/res/animation
-END VERIFY SCRIPT-

80968cff68

Bushstar force-pushed on Jun 29, 2020
Bushstar commented at 6:05 PM on June 29, 2020: contributor

@hebasto CI failed on the last effort due to scripted-diff. I did not also rename the folder via script. First time using scripted-diff!

https://travis-ci.org/github/bitcoin-core/gui/jobs/703204253#L422

Now created the entire commit via command line and added those same commands to the scripted-diff. Hopefully this time it will succeed. I'll keep an eye on it and update it as needed. Thanks everyone for your patience.
Bushstar commented at 4:30 AM on June 30, 2020: contributor

@fanquake looks like all tests should pass but one build ran out of time, please give it a nudge.
hebasto commented at 5:17 AM on June 30, 2020: member

@Bushstar

@fanquake looks like all tests should pass but one build ran out of time, please give it a nudge.

It is a known problem. See #12.
hebasto commented at 7:07 AM on June 30, 2020: member

Concept ACK.
MarcoFalke commented at 12:39 PM on July 15, 2020: contributor

ACK 80968cff68f4d11d98a2a6670846eafbb2803f4f
hebasto approved
hebasto commented at 7:32 AM on July 16, 2020: member

ACK 80968cff68f4d11d98a2a6670846eafbb2803f4f, tested on Linux Mint 20 (Qt 5.12.8).
MarcoFalke merged this on Jul 16, 2020
MarcoFalke closed this on Jul 16, 2020
sidhujag referenced this in commit 9a6234ae77 on Jul 18, 2020
laanwj referenced this in commit 924a4ff7eb on Oct 29, 2020
apoelstra referenced this in commit b5383e57a3 on Dec 3, 2020
gwillen referenced this in commit f93efd3007 on Mar 19, 2021
MarcoFalke referenced this in commit bce09da122 on Apr 28, 2021
fanquake referenced this in commit fa00bb2c5c on Apr 29, 2021
MarcoFalke referenced this in commit eb9a1fe037 on May 7, 2021
MarcoFalke referenced this in commit c857148636 on May 15, 2021
deadalnix referenced this in commit 8a8c0b1c81 on Sep 1, 2021
bitcoin-core locked this on Feb 15, 2022

Contributors

Linked (view graph)

#7 Crash on exit #247 bitcoin-qt stays at "Done loading" for a long time #545 SIGABRT on macOS after Dock menu --> Quit #668 Got stuck in "loading wallets", then segfault on closing #689 Segmentation fault when closing while loading wallets #785 New crash in v26.0 #796 ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in #880 SegFault in QSortFilterProxyModelPrivate::build_source_to_proxy_mapping