Locks are no longer taken upfront, so remove the outdated comment
doc: Remove outdated comment in TransactionTablePriv #17
pull MarcoFalke wants to merge 1 commits into bitcoin-core:master from MarcoFalke:2007-qtDoc changing 1 files +3 −8-
MarcoFalke commented at 11:29 PM on June 30, 2020: contributor
-
doc: Remove outdated comment in TransactionTablePriv faebb60b8d
- MarcoFalke added the label Doc on Jun 30, 2020
- hebasto approved
-
hebasto commented at 5:17 AM on July 1, 2020: member
ACK faebb60b8d009e52d585cffd0f124a0f2fd1a66d, I have reviewed the code and it looks OK, I agree it can be merged.
The removed comment was added in https://github.com/bitcoin/bitcoin/pull/4085 along with the
TRY_LOCK(cs_main, lockMain);line which is not present in the code now. - MarcoFalke merged this on Jul 1, 2020
- MarcoFalke closed this on Jul 1, 2020
- MarcoFalke deleted the branch on Jul 1, 2020
- laanwj referenced this in commit 924a4ff7eb on Oct 29, 2020
- apoelstra referenced this in commit eb98a835f3 on Dec 3, 2020
- gwillen referenced this in commit f29422f885 on Mar 19, 2021
- MarcoFalke referenced this in commit bce09da122 on Apr 28, 2021
- MarcoFalke referenced this in commit eb9a1fe037 on May 7, 2021
- MarcoFalke referenced this in commit c857148636 on May 15, 2021
- PastaPastaPasta referenced this in commit f1a3f61dfe on Jun 27, 2021
- PastaPastaPasta referenced this in commit 7f46c0d792 on Jun 28, 2021
- PastaPastaPasta referenced this in commit 0940f77755 on Jun 29, 2021
- PastaPastaPasta referenced this in commit d7816cec5f on Jul 1, 2021
- PastaPastaPasta referenced this in commit a8fc38e21b on Jul 1, 2021
- PastaPastaPasta referenced this in commit 66f65c29a6 on Jul 15, 2021
- PastaPastaPasta referenced this in commit 26a5c857aa on Jul 16, 2021
- Fabcien referenced this in commit c3833ecf94 on Aug 30, 2021
- bitcoin-core locked this on Feb 15, 2022
Contributors
Labels
Linked (view graph)
#7 Crash on exit#247 bitcoin-qt stays at "Done loading" for a long time#545 SIGABRT on macOS after Dock menu --> Quit#668 Got stuck in "loading wallets", then segfault on closing#689 Segmentation fault when closing while loading wallets#785 New crash in v26.0#796 ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in#880 SegFault in QSortFilterProxyModelPrivate::build_source_to_proxy_mapping