Support backup to new text-based database dump format #230

pull luke-jr wants to merge 4 commits into bitcoin-core:master from luke-jr:gui_backup_formats changing 6 files +45 −17

luke-jr commented at 5:34 pm on February 27, 2021: member

Note: Leaving out the RPC dumpwallet format because it stores an encrypted wallet as unencrypted. If that’s desirable to support at all, it can be a followup PR (perhaps with a strong warning).
Wallet: Pass dump_filename to DumpWallet as an argument 9517b59e30
interfaces/Wallet: Add the ability to choose a backup format
Also outputs a bilingual_str error (unused for now)
15a024621e
interfaces/Wallet: Add DumpWallet format to backupWallet interface a662318fc0
GUI: Support backup to DumpWallet format e91a3f39d0
hebasto commented at 6:50 pm on February 27, 2021: member

What use cases do you see for such a feature?
luke-jr commented at 6:53 pm on February 27, 2021: member

Personal preference? Dunno, @achow101, what use cases did you have in mind for this dump format?

(I’m not adding the new format here, mind you, simply making it available to GUI users)
achow101 commented at 7:00 pm on February 27, 2021: member

I’m not sure how useful this is. There were two primary reasons for adding the dump and createfromdump commands: 1) To make it easier to debug low level database record issues and 2) to make it possible to change the database storage type without changing the wallet level logic. In the second case, this is not something that we really want people to do but I wanted to be able to do it at least just for testing.
DrahtBot commented at 1:40 pm on March 16, 2021: contributor

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.
DrahtBot added the label Needs rebase on Mar 16, 2021
hebasto added the label Feature on Mar 25, 2021
hebasto added the label Wallet on Apr 19, 2021
luke-jr commented at 1:34 am on September 8, 2021: member

Closing due to lack of interest. Will continue to rebase for Knots, so if anyone cares, I can reopen easily.
luke-jr closed this on Sep 8, 2021
bitcoin-core locked this on Sep 8, 2022

Contributors
luke-jr hebasto achow101 DrahtBot

Labels
Needs rebase Feature Wallet