Add “Copy address” item to the context menu in the Peers table #264

1. 
   hebasto commented at 6:28 am on March 30, 2021: member

   It seems a useful feature. Related to #262.
2. hebasto added the label Feature on Mar 30, 2021
3. 
   ghost commented at 6:27 pm on March 30, 2021: none

   Thanks, I applied only the last commit 03a2b7426446693505af66280fd6868c210bd035 to the master branch, built it on Debian 10 Buster, and copying of the node address incl. port works. One can afterwards paste it from the clipboard. I do not understand the code, just applied and tested it. Screenshot:

   

4. 
   jarolrod commented at 5:23 pm on April 5, 2021: member

   Concept ACK

   since we are adding the ability to copy the address, is there any reason to still allow this to show up/be clicked on:

   

5. 
   hebasto commented at 11:36 pm on April 5, 2021: member

   since we are adding the ability to copy the address, is there any reason to still allow this to show up/be clicked on:

   Why not?

6. DrahtBot added the label Needs rebase on Apr 14, 2021
7. hebasto force-pushed on Apr 14, 2021
8. 
   hebasto commented at 4:09 pm on April 14, 2021: member

   Rebased 03a2b7426446693505af66280fd6868c210bd035 -> bb36f6e60b961d50b753c35e36c1833f862f8b0c (pr264.01 -> pr264.02) due to the conflict with #260.
9. DrahtBot removed the label Needs rebase on Apr 14, 2021
10. 
    jarolrod commented at 2:55 am on April 16, 2021: member

    tACK bb36f6e60b961d50b753c35e36c1833f862f8b0c

    Tested on macOS 11.2.3 Qt 5.15.2. The menu action works as it should.

    #263, which this is based on, is on my plate to review for tomorrow. 🥃

11. 
    promag commented at 11:26 am on April 17, 2021: contributor

    If you copy a row with the keyboard shortcut and paste it you will get rubbish.
12. 
    hebasto commented at 12:21 pm on April 17, 2021: member

    @promag

    If you copy a row with the keyboard shortcut and paste it you will get rubbish.

    I suppose you are testing on macOS, no?

13. 
    hebasto commented at 1:38 pm on April 17, 2021: member

    @promag

    If you copy a row with the keyboard shortcut and paste it you will get rubbish.

    It appears, the problem is much bigger, at least on Linux – see #283.

    Although keyboard shortcuts are out of this PR scope, do you think it’d better to postpone this PR until #283 is fixed?

14. 
    promag commented at 9:08 am on April 23, 2021: contributor

    Needs rebase.
15. 
    MarcoFalke commented at 9:41 am on April 23, 2021: contributor

    Needs rebase.

    why?

16. 
    promag commented at 9:42 am on April 23, 2021: contributor

    Needs rebase.

    why?

    Right, it doesn’t actually need, just github showing more commits.

17. MarcoFalke force-pushed on Apr 23, 2021
18. 
    MarcoFalke commented at 9:50 am on April 23, 2021: contributor

    Ok, I removed commits from showing up
19. DrahtBot added the label Needs rebase on Apr 28, 2021
20. 
    DrahtBot commented at 6:30 pm on April 28, 2021: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

21. qt: Add "Copy address" item to the context menu in the Peers table 6d6219bdf8
22. hebasto force-pushed on Apr 28, 2021
23. 
    hebasto commented at 8:13 pm on April 28, 2021: member

    Rebased due to the conflict with #18. @promag

    If you copy a row with the keyboard shortcut and paste it you will get rubbish.

    This is fixed in #18.

24. hebasto marked this as a draft on Apr 28, 2021
25. 
    hebasto commented at 8:23 pm on April 28, 2021: member

    This branch is currently broken, leaving it for now up for grabs.
26. hebasto closed this on Apr 28, 2021

    ---

27. hebasto removed the label Needs rebase on Apr 28, 2021
28. hebasto added the label up for grabs on Apr 28, 2021
29. 
    jarolrod commented at 3:19 pm on May 26, 2021: member

    @hebasto no longer up for grabs, picked up in #318
30. hebasto removed the label Feature on May 26, 2021
31. hebasto removed the label up for grabs on May 26, 2021
32. hebasto added the label UX on May 26, 2021
33. hebasto referenced this in commit ee1db7b6dc on Sep 12, 2021
34. bitcoin-core locked this on Aug 16, 2022

Contributors
hebasto ghost jarolrod promag MarcoFalke DrahtBot

Labels
UX