Do not use QClipboard::Selection on Windows and macOS. #277

1. 
   hebasto commented at 12:11 PM on April 10, 2021: member

   Windows and macOS do not support the global mouse selection.

   Fixes #258.

2. hebasto added the label Bug on Apr 10, 2021
3. hebasto added the label macOS on Apr 10, 2021
4. hebasto added the label windows on Apr 10, 2021
5. in src/qt/guiutil.cpp:632 in ad87cef8f0 outdated

    628 | @@ -629,7 +629,10 @@ bool SetStartOnSystemStartup(bool fAutoStart) { return false; }
    629 |  void setClipboard(const QString& str)
    630 |  {
    631 |      QApplication::clipboard()->setText(str, QClipboard::Clipboard);
    632 | +#if !defined(Q_OS_WIN) && !defined(Q_OS_MAC)
   

   ---

   ---

   

   promag commented at 6:28 PM on April 10, 2021:

   Use QClipboard::supportsSelection() instead.

   ---

   

   hebasto commented at 6:46 PM on April 10, 2021:

   Thanks!

6. 
   promag commented at 6:28 PM on April 10, 2021: contributor

   Concept ACK.

7. qt: Do not use QClipboard::Selection on Windows and macOS.

   Windows and macOS do not support the global mouse selection.

   7f3a5980c1
8. hebasto force-pushed on Apr 10, 2021
9. 
   promag commented at 6:37 PM on April 10, 2021: contributor

   Code review ACK 7f3a5980c1d54988a707b961fd2ef647cebb4c5b.

10. 
    jarolrod commented at 8:44 PM on April 11, 2021: member

    ACK 7f3a5980c1d54988a707b961fd2ef647cebb4c5b

    EDIT: This still shows up on > Qt 5.9.8 when running with -debug=qt. Tested that this PR fixes the issue on macOS 11.2.3

    But I cannot replicate the issue described in #258 when compiling master with Qt 5.15.2 or building master with depends which uses Qt 5.12.10

    I can replicate the issue when building the 0.21 tag with depends (Qt 5.9.8). I think the issue linked is not a problem anymore going forward

11. 
    hebasto commented at 10:34 AM on April 17, 2021: member

    @streamofstars Does this work for you?

12. 
    MarcoFalke commented at 11:29 AM on April 17, 2021: contributor

    Is this for backport to 0.21?

13. MarcoFalke merged this on Apr 17, 2021
14. MarcoFalke closed this on Apr 17, 2021

    ---

15. hebasto deleted the branch on Apr 17, 2021
16. 
    hebasto commented at 11:36 AM on April 17, 2021: member

    Is this for backport to 0.21?

    Yes, I guess.

17. MarcoFalke added the label needs backport (0.21) on Apr 17, 2021
18. MarcoFalke added this to the milestone 0.21.2 on Apr 17, 2021
19. sidhujag referenced this in commit 41c8cc274f on Apr 17, 2021
20. hebasto referenced this in commit f220368220 on Jul 11, 2021
21. 
    hebasto commented at 9:23 AM on July 11, 2021: member

    Backported in https://github.com/bitcoin/bitcoin/pull/22427.

22. hebasto removed the label needs backport (0.21) on Jul 11, 2021
23. fanquake referenced this in commit 997e528a34 on Jul 29, 2021
24. ComputerCraftr referenced this in commit 92a0234680 on Aug 18, 2021
25. gwillen referenced this in commit 4ea4b46b9a on Jun 1, 2022
26. bitcoin-core locked this on Aug 16, 2022

Contributors

hebastopromagjarolrodMarcoFalke

Milestone
0.21.2