This PR doesn't change behaviour, removes the coin control argument from updateCoinControlState since it's a class member.
refactor: Simplify SendCoinsDialog::updateCoinControlState #284
pull promag wants to merge 1 commits into bitcoin-core:master from promag:2021-04-sendcoinsdialog changing 2 files +10 −11-
promag commented at 8:16 PM on April 18, 2021: contributor
-
refactor, qt: Simplify SendCoinsDialog::updateCoinControlState 5f438d66c1
- hebasto added the label Refactoring on Apr 18, 2021
- hebasto added the label Wallet on Apr 19, 2021
- hebasto renamed this:
refactor, qt: Simplify SendCoinsDialog::updateCoinControlState
refactor: Simplify SendCoinsDialog::updateCoinControlState
on Apr 19, 2021 -
hebasto commented at 4:49 PM on April 20, 2021: member
Concept ACK on simplifying code.
- hebasto approved
-
hebasto commented at 6:11 PM on April 20, 2021: member
ACK 5f438d66c1fbc0e524d12fef233f2ed2952e6f17, I have reviewed the code and it looks OK, I agree it can be merged.
I see this change as a nice https://github.com/bitcoin/bitcoin/pull/18894 follow up.
-
jonatack commented at 9:32 AM on April 23, 2021: contributor
Nice simplification.
Code review ACK 5f438d66c1fbc0e524d12fef233f2ed2952e6f17
- kristapsk approved
-
kristapsk commented at 1:24 PM on April 25, 2021: contributor
utACK 5f438d66c1fbc0e524d12fef233f2ed2952e6f17. Code looks correct.
- hebasto merged this on Apr 25, 2021
- hebasto closed this on Apr 25, 2021
- sidhujag referenced this in commit de9b077ba3 on Apr 25, 2021
- promag deleted the branch on Apr 26, 2021
- gwillen referenced this in commit 3479bcceec on Jun 1, 2022
- bitcoin-core locked this on Aug 16, 2022
