scripted-diff: Make SeparatorStyle a scoped enum #3

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:200618-sep-enum changing 9 files +37 −37

hebasto commented at 12:36 PM on June 18, 2020: member

This PR is split from https://github.com/bitcoin/bitcoin/pull/17877 and makes BitcoinUnits::SeparatorStyle a scoped enum.

scripted-diff: Make SeparatorStyle a scoped enum

-BEGIN VERIFY SCRIPT-
# General rename helper: $1 -> $2
rename_global() { sed -i "s/\<$1\>/$2/g" $(git grep -l "$1"); }

# Helper to rename SeparatorStyle enumerators
rename_value() {
  sed -i "s/    $1/    $2/g" src/qt/bitcoinunits.h;
  rename_global $1 "SeparatorStyle::$2";
}

rename_global 'enum SeparatorStyle' 'enum class SeparatorStyle'
rename_value 'separatorNever' 'NEVER'
rename_value 'separatorStandard' 'STANDARD'
rename_value 'separatorAlways' 'ALWAYS'
-END VERIFY SCRIPT-

25f3554351

MarcoFalke commented at 12:41 PM on June 18, 2020: contributor

review ACK 25f3554351a99a0a695fbd2a6a0f293b3adc3d98 🚐

<details><summary>Show signature and timestamp</summary>

Signature:

Timestamp of file with hash c2e1cf19f50c853bf07d563749f5d51b4e929abb7cf80d7eb4a46e25822b5ac1 -

</details>

MarcoFalke added the label refactoring on Jun 18, 2020
MarcoFalke merged this on Jun 18, 2020
MarcoFalke closed this on Jun 18, 2020
hebasto deleted the branch on Jun 18, 2020
laanwj referenced this in commit 31bdd86631 on Jul 15, 2020
laanwj referenced this in commit 924a4ff7eb on Oct 29, 2020
MarcoFalke referenced this in commit 027e51f715 on Nov 12, 2020
jonasschnelli referenced this in commit c33662a0ea on Dec 2, 2020
apoelstra referenced this in commit 6cb81893a3 on Dec 3, 2020
laanwj referenced this in commit e520e091db on Jan 6, 2021
gwillen referenced this in commit c3b6bbba4a on Mar 19, 2021
MarcoFalke referenced this in commit 590e49ccf2 on Apr 4, 2021
MarcoFalke referenced this in commit bce09da122 on Apr 28, 2021
fanquake referenced this in commit fa00bb2c5c on Apr 29, 2021
MarcoFalke referenced this in commit eb9a1fe037 on May 7, 2021
laanwj referenced this in commit ee9befe8b4 on May 12, 2021
MarcoFalke referenced this in commit c857148636 on May 15, 2021
deadalnix referenced this in commit b75671eabc on Aug 26, 2021
MarcoFalke referenced this in commit eb1f5706df on Sep 9, 2021
fanquake referenced this in commit fad381b2f8 on Jan 7, 2022
MarcoFalke referenced this in commit 444b6b342d on Feb 15, 2022
bitcoin-core locked this on Feb 15, 2022

Contributors

hebasto

MarcoFalke

Labels

Refactoring

Linked (view graph)

#7 Crash on exit #247 bitcoin-qt stays at "Done loading" for a long time #545 SIGABRT on macOS after Dock menu --> Quit #668 Got stuck in "loading wallets", then segfault on closing #689 Segmentation fault when closing while loading wallets #785 New crash in v26.0 #796 ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in #805 implicit-integer-sign-change wallet/interfaces.cpp:289:57 #880 SegFault in QSortFilterProxyModelPrivate::build_source_to_proxy_mapping