External Signer can be enabled even when external signer script is not set #395

1. 
   jarolrod commented at 3:04 am on August 4, 2021: member

   The External Signer option when creating a wallet is supposed to be disabled while the external signer script has not been set in settings. There is a way to enable this option even though the script has not been set, then if you were to create an External Signer wallet the gui will crash because the external signer script was never set:

   0terminate called after throwing an instance of 'std::runtime_error'
   1  what():  GetExternalSigner: restart bitcoind with -signer=<cmd>
   2Aborted (core dumped)
   

   Steps to reproduce:

   No special preparation. Just required that the external signer script has not be set in settings. This is to ensure that proper functionality is that the External Signer script option is supposed to be disabled.

   1. Go to create a new wallet
   2. Notice that the External Signer option is disabled, as it is supposed to be
   3. Select, then de-select Encrypt Wallet
   4. The External Signer option is now enabled, when it is not supposed to be
   5. Select the now enabled External Signer option and create wallet
   6. GUI will crash
2. jarolrod added the label Bug on Aug 4, 2021
3. hebasto added the label UX on Aug 4, 2021
4. hebasto added the label Wallet on Aug 4, 2021
5. 
   Rspigler commented at 9:36 am on August 6, 2021: contributor

   When you say:

   The External Signer option is disabled

   do you mean the External Signer script path remains empty, or is there some other option I am missing?

6. hebasto closed this on Aug 6, 2021

   ---

7. bitcoin-core locked this on Aug 16, 2022

Contributors
jarolrod Rspigler

Labels
Bug Wallet UX