Ensure external signer option remains disabled without signers #396

1. 
   achow101 commented at 3:34 am on August 6, 2021: member

   When no external signers are available, the option to enable external signers should always be disabled. However the encrypt wallet checkbox can erroneously re-enable the external signer checkbox. To avoid this, CreateWalletDialog now stores whether signers were available during setSigners so that future calls to external_signer_checkbox->setEnabled can account for whether signers are available.

   Fixes #395

2. gui: ensure external signer option remains disabled without signers

   When no external signers are available, the option to enable external
   signers should always be disabled. However the encrypt wallet checkbox
   can erroneously re-enable the external signer checkbox. To avoid this,
   CreateWalletDialog now stores whether signers were available during
   setSigners so that future calls to external_signer_checkbox->setEnabled
   can account for whether signers are available.

   a9b9ca82da
3. 
   achow101 commented at 3:34 am on August 6, 2021: member

   Needs backport to 22.0
4. jarolrod added the label Bug on Aug 6, 2021
5. jarolrod added the label Wallet on Aug 6, 2021
6. MarcoFalke added the label Needs backport (22.x) on Aug 6, 2021
7. MarcoFalke added this to the milestone 22.0 on Aug 6, 2021
8. hebasto renamed this:
   gui: ensure external signer option remains disabled without signers
   Ensure external signer option remains disabled without signers
   on Aug 6, 2021
9. in src/qt/createwalletdialog.cpp:35 in a9b9ca82da

   31@@ -32,7 +32,7 @@ CreateWalletDialog::CreateWalletDialog(QWidget* parent) :
   32         // set to true, enable it when isEncryptWalletChecked is false.
   33         ui->disable_privkeys_checkbox->setEnabled(!checked);
   34 #ifdef ENABLE_EXTERNAL_SIGNER
   35-        ui->external_signer_checkbox->setEnabled(!checked);
   36+        ui->external_signer_checkbox->setEnabled(m_has_signers && !checked);
   

   ---

   ---

   

   hebasto commented at 7:33 am on August 6, 2021:

   Maybe

   0        if (m_has_signers) {
   1            ui->external_signer_checkbox->setEnabled(!checked);
   2        }
   

   to make the same code structure as it is in CreateWalletDialog::setSigners for better readability?

10. hebasto approved
11. 
    hebasto commented at 7:36 am on August 6, 2021: member

    ACK a9b9ca82daefc77ee3c884d3f250460d7cf734a5, tested on Linux Mint 20.2 (Qt 5.12.8).
12. hebasto requested review from Sjors on Aug 6, 2021
13. hebasto requested review from jarolrod on Aug 6, 2021
14. hebasto requested review from meshcollider on Aug 6, 2021
15. Sjors approved
16. 
    Sjors commented at 3:20 pm on August 6, 2021: member

    tACK a9b9ca82daefc77ee3c884d3f250460d7cf734a5
17. 
    jarolrod commented at 4:10 pm on August 6, 2021: member

    ACK a9b9ca82daefc77ee3c884d3f250460d7cf734a5

    Extensively tested on Ubuntu 20.04. Thank you for the speedy fix!

18. hebasto merged this on Aug 6, 2021
19. hebasto closed this on Aug 6, 2021

    ---

20. hebasto referenced this in commit 2d932df286 on Aug 6, 2021
21. 
    hebasto commented at 4:19 pm on August 6, 2021: member

    Backported in https://github.com/bitcoin/bitcoin/pull/22629.
22. hebasto removed the label Needs backport (22.x) on Aug 6, 2021
23. sidhujag referenced this in commit 76edf19418 on Aug 6, 2021
24. hebasto referenced this in commit b531c3aa10 on Aug 7, 2021
25. hebasto referenced this in commit 14505bab55 on Aug 9, 2021
26. hebasto referenced this in commit e05567555a on Aug 9, 2021
27. hebasto referenced this in commit c90a33c871 on Aug 19, 2021
28. hebasto referenced this in commit 7017990a43 on Aug 20, 2021
29. hebasto referenced this in commit 9ea641d0c0 on Aug 20, 2021
30. hebasto referenced this in commit 6a611d2e3c on Aug 20, 2021
31. laanwj referenced this in commit 4a25e39624 on Aug 26, 2021
32. fujicoin referenced this in commit 7dc07f28ad on Aug 27, 2021
33. gwillen referenced this in commit 7b7008f026 on Jul 27, 2022
34. gwillen referenced this in commit 0608e9958f on Aug 1, 2022
35. bitcoin-core locked this on Aug 16, 2022

Contributors
achow101 hebasto Sjors jarolrod

Review Requested
meshcollider

Labels
Bug Wallet

Milestone
22.0