Clarify block height label #40

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:200725-height changing 1 files +1 −1

hebasto commented at 5:45 PM on July 25, 2020: member

Prefer "block height" instead of "number of blocks".

This was done while testing https://github.com/bitcoin/bitcoin/pull/16981.
gui: Clarify block height label b6dcc6d741
hebasto renamed this:
~~gui: Clarify block height label~~
Clarify block height label
on Jul 25, 2020

in src/qt/forms/debugwindow.ui:293 in b6dcc6d741

 289 | @@ -290,7 +290,7 @@
 290 |         <item row="11" column="0">
 291 |          <widget class="QLabel" name="label_3">
 292 |           <property name="text">
 293 | -          <string>Current number of blocks</string>
 294 | +          <string>Current block height</string>

promag commented at 11:11 AM on July 26, 2020:

Funny that "height" is not in the translations.

michaelfolkson commented at 11:23 AM on August 14, 2020: member

ACK b6dcc6d74186eee15eda2cb6e8a7ab5b5b4a05f8. I don't think there are any other obvious examples in the GUI where "block height" should replace "number of blocks" except for translations.

MarcoFalke commented at 5:55 PM on August 27, 2020: contributor

$ git grep --ignore-case 'block height' | wc
     65     793    7793
$ git grep --ignore-case 'number of blocks' | wc
    141    1125   12941

hebasto commented at 6:27 PM on August 27, 2020: member

$ git grep --ignore-case 'block height' -- :^doc/release-notes :^src/qt/locale | wc -l
60
$ git grep --ignore-case 'number of blocks' -- :^doc/release-notes :^src/qt/locale | wc -l
37

MarcoFalke commented at 6:29 PM on August 27, 2020: contributor

Fair enough. I wanted to show that both wordings are used, so it seems arbitrary to change only one?
MarcoFalke commented at 6:30 PM on August 27, 2020: contributor

cr ACK b6dcc6d74186eee15eda2cb6e8a7ab5b5b4a05f8

probably doesn't matter much, but shouldn't hurt either
hebasto commented at 6:31 PM on August 27, 2020: member

Fair enough. I wanted to show that both wordings are used, so it seems arbitrary to change only one?

In the GUI this is one, I guess.
MarcoFalke commented at 6:33 PM on August 27, 2020: contributor

block height is probably better because it implies linearity (chain) instead of number of blocks, which could also mean the number of blocks in the block tree.
MarcoFalke merged this on Aug 27, 2020
MarcoFalke closed this on Aug 27, 2020
hebasto commented at 6:35 PM on August 27, 2020: member

@MarcoFalke

block height is probably better because it implies linearity (chain) instead of number of blocks, which could also mean the number of blocks in the block tree.

Exactly.
hebasto deleted the branch on Aug 27, 2020
sidhujag referenced this in commit 9c0a0b14dd on Aug 28, 2020
apoelstra referenced this in commit 7b52befaa2 on Dec 3, 2020
laanwj referenced this in commit 90c0f267bd on Dec 9, 2020
gwillen referenced this in commit 264dff362e on Mar 22, 2021
PastaPastaPasta referenced this in commit 843c166c62 on Jun 27, 2021
PastaPastaPasta referenced this in commit 53dd955007 on Jun 28, 2021
PastaPastaPasta referenced this in commit 81b6e725af on Jun 29, 2021
PastaPastaPasta referenced this in commit 8d04b42f5f on Jul 1, 2021
PastaPastaPasta referenced this in commit 901b101fb4 on Jul 1, 2021
PastaPastaPasta referenced this in commit 3122a6b5a6 on Jul 15, 2021
PastaPastaPasta referenced this in commit cd741d0d4d on Jul 16, 2021
Fabcien referenced this in commit 6e51b724e9 on Sep 16, 2021
bitcoin-core locked this on Feb 15, 2022

Contributors