Ensure translator comments end in full stop #420

1. 
   jarolrod commented at 10:29 pm on September 12, 2021: member

   This is a follow-up to #318 which addresses this nit by addressing it globally.

   This ensures that all GUI translator comments end in a full stop. If a comment does not end in a full stop, a translator may think that the rest of the comment is being cut off.

   While here, add a colon to the word “see” for any comments touched which point to look at a link.

2. qt: ensure translator comments end in full stop

   This ensures that all gui translator comments end in a full stop.
   If a comment does not end in a full stop, a translator may think 
   that the rest of the comment is being cut off.
   
   While here, add a colon to the word "see" for any comments
   touched which point to look at a link.

   5cc783f5f3
3. jarolrod added the label Translations on Sep 12, 2021
4. hebasto approved
5. 
   hebasto commented at 7:23 am on September 13, 2021: member

   ACK 5cc783f5f32ffd550d1b298fc2e9cf6c0439f9fe, I have reviewed the code and it looks OK, I agree it can be merged.
6. 
   jonatack commented at 2:02 pm on September 13, 2021: contributor

   Light ACK.

   I’m not sure about appending a full stop to URLs, but I don’t know what the translator UX is like.

7. 
   hebasto commented at 3:01 pm on September 13, 2021: member

   I’m not sure about appending a full stop to URLs, but I don’t know what the translator UX is like.

   I think it’s ok as the Transifex recognizes links:

   

8. shaavan approved
9. 
   shaavan commented at 4:51 pm on September 13, 2021: contributor

   Code Review ACK 5cc783f5f32ffd550d1b298fc2e9cf6c0439f9fe

   The changes made here look good. Also, I checked and couldn’t find any translator comment in src/qt that does not end in full stop and is not addressed here.

   This is a small but necessary change to maintain the consistency of translators’ comments. Great work, @jarolrod!

10. hebasto merged this on Sep 14, 2021
11. hebasto closed this on Sep 14, 2021

    ---

12. sidhujag referenced this in commit e5c2a8a01a on Sep 15, 2021
13. bitcoin-core locked this on Sep 14, 2022

Contributors
jarolrod hebasto jonatack shaavan

Labels
Translations