Enables a tooltip on the graph to make it easier to see what point in time a part of the graph corresponds to.
This PR includes the change in #484, but also deals with the potential issues that the simplicity of 484 introduced.
TODO:
Concept ACK
I think this PR is an improvement from a UX perspective. I shall be testing this PR when the TODO is completed.
389+ if (value < 1'000) return strprintf(strprintf("%%.%df %s%%s", std::max(dp - 3, 0), letter), value, strUnit);
390+
391+ return strprintf(strprintf("%%.%df %s%%s", std::max(dp - 4, 0), letter), value, strUnit);
392+}
393+
394+std::string strBps(float bits) {
I’d fancy reviewing this, but my time is very limited. As you keep finishing PRs, I could use some meta issue (or something) helping me realize the dependency tree between PRs without me having to spend time figuring it out. Cheers,
On Tue, Dec 7, 2021 at 10:42 AM Rebroad @.***> wrote:
@.**** commented on this pull request.
In src/util/strencodings.cpp https://github.com/bitcoin-core/gui/pull/492#discussion_r763811501:
- } else if (value < 1'000'000'000) {
letter = "M";value /= 1'000'000;- } else {
letter = "G";value /= 1'000'000'000;- }
- if (value < 1) return strprintf(strprintf("%%.%df %s%%s", dp, letter), value, strUnit);
- if (value < 10) return strprintf(strprintf("%%.%df %s%%s", std::max(dp - 1, 0), letter), value, strUnit);
- if (value < 100) return strprintf(strprintf("%%.%df %s%%s", std::max(dp - 2, 0), letter), value, strUnit);
- if (value < 1'000) return strprintf(strprintf("%%.%df %s%%s", std::max(dp - 3, 0), letter), value, strUnit);
- return strprintf(strprintf("%%.%df %s%%s", std::max(dp - 4, 0), letter), value, strUnit); +}
+std::string strBps(float bits) {
This isn’t used by this PR, but is planned to be used in #305 https://github.com/bitcoin-core/gui/pull/305
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/492#pullrequestreview-825023047, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4WYRUK34NOVAYWUPPBDUPXJHPANCNFSM5JEVGYYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
I’d fancy reviewing this, but my time is very limited. As you keep finishing PRs, I could use some meta issue (or something) helping me realize the dependency tree between PRs without me having to spend time figuring it out. Cheers,
Hi. The latest push to this PR ought to be the last one - I had been trying to get the ToolTips to behave better, which they now do. They no longer time-out (disappear) and they also can now moved along with the graph regardless of the duration/speed selected. Also, the yellow circle will disappear more reliably now if the ToolTip also disappears (due to the mouse pointing elsewhere). It took a while to refine this functionality, which in the latest commit required an additional timer (tt_timer) to check the ToolTip status at an interval independent of the graph being updated, or the mouse moving.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
178+ if (ttpoint >= 0 && ttpoint < sampleCount) {
179+ painter.setPen(Qt::yellow);
180+ int w = width() - XMARGIN * 2;
181+ int x = XMARGIN + w - w * ttpoint / DESIRED_SAMPLES;
182+ int y = y_value(floatmax(vSamplesIn.at(ttpoint), vSamplesOut.at(ttpoint)));
183+ painter.drawEllipse(QPointF(x, y), 3, 3);
261@@ -262,8 +262,7 @@ void TrafficGraphWidget::setGraphRangeMins(int mins)
262 int msecsPerSample = nMins * 60 * 1000 / DESIRED_SAMPLES;
263 timer->stop();
264 timer->setInterval(msecsPerSample);
265-
266- clear();
267+ timer->start();
🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.
#473 is similarly inactive.
On Thu, May 26, 2022 at 7:22 PM Hennadii Stepanov @.***> wrote:
Closing due to a long period of inactivity here. Feel free to reopen.
— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/492#issuecomment-1138821055, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W7L4JVJ3LULH5S767TVL6XMDANCNFSM5JEVGYYQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>