refactor: Declare WalletModel member functions with const #590

1. 
   hebasto commented at 12:36 pm on April 23, 2022: member

   After bitcoin/bitcoin#12830 the WalletModel class has two member functions: https://github.com/bitcoin-core/gui/blob/be7a5f2fc400e7a3ef72dedbdcf49dd6c96d4f9e/src/qt/walletmodel.h#L81 and https://github.com/bitcoin-core/gui/blob/be7a5f2fc400e7a3ef72dedbdcf49dd6c96d4f9e/src/qt/walletmodel.h#L154

   This PR drops the former one as redundant, and declares WalletModel member functions with the const qualifier where appropriate.

2. qt, refactor: Declare `WalletModel` member functions with `const` f70ee34c71
3. hebasto added the label Refactoring on Apr 23, 2022
4. hebasto added the label Wallet on Apr 23, 2022
5. 
   promag commented at 1:46 pm on May 9, 2022: contributor

   Code review ACK f70ee34c71aeeb814fe65a69952343dccdb7b906.
6. kristapsk approved
7. 
   kristapsk commented at 2:56 pm on May 9, 2022: contributor

   cr ACK f70ee34c71aeeb814fe65a69952343dccdb7b906
8. w0xlt approved
9. 
   w0xlt commented at 3:04 pm on May 9, 2022: contributor

   Code Review ACK https://github.com/bitcoin-core/gui/pull/590/commits/f70ee34c71aeeb814fe65a69952343dccdb7b906
10. hebasto merged this on May 9, 2022
11. hebasto closed this on May 9, 2022

    ---

12. hebasto deleted the branch on May 9, 2022
13. sidhujag referenced this in commit 1f06e69edf on May 9, 2022
14. bitcoin-core locked this on May 9, 2023

Contributors
hebasto promag kristapsk w0xlt

Labels
Refactoring Wallet