wallet, refactor: Make WalletModel::sendCoins() return void #608

1. 
   hebasto commented at 3:50 pm on May 29, 2022: member

   Currently, the WalletModel::sendCoins() function always returns the same value.

   Also dead and noop (calling processSendCoinsReturn(OK)) code has been removed.

   The other return statements have been removed from the WalletModel::sendCoins() function in bitcoin/bitcoin#17154 and bitcoin/bitcoin#17165.

2. qt, wallet, refactor: Make `WalletModel::sendCoins()` return `void`

   Currently, the `WalletModel::sendCoins()` function always returns the
   same value.
   
   Also dead and noop code has been removed.

   1f653dc262
3. hebasto added the label Refactoring on May 29, 2022
4. hebasto added the label Wallet on May 29, 2022
5. hebasto renamed this:
   qt, wallet, refactor: Make `WalletModel::sendCoins()` return `void`
   wallet, refactor: Make `WalletModel::sendCoins()` return `void`
   on May 29, 2022
6. kristapsk approved
7. 
   kristapsk commented at 4:18 pm on May 29, 2022: contributor

   cr ACK 1f653dc2623ee2be3e1eeeaf5ce0e97966cecd6a
8. furszy approved
9. 
   furszy commented at 6:07 pm on May 29, 2022: contributor

   Code review ACK 1f653dc2

   Reviewing this found https://github.com/bitcoin/bitcoin/pull/25239, so thanks for the push into the right direction hehe.

10. shaavan approved
11. 
    shaavan commented at 7:44 am on June 12, 2022: contributor

    Code Review ACK 1f653dc2623ee2be3e1eeeaf5ce0e97966cecd6a

    • It is an excellent cleanup, which eliminates a redundant return value and the need to check it under a conditional statement later.

    Nice catch, @hebasto!

12. w0xlt approved
13. 
    w0xlt commented at 10:12 am on June 12, 2022: contributor

    Code Review ACK https://github.com/bitcoin-core/gui/pull/608/commits/1f653dc2623ee2be3e1eeeaf5ce0e97966cecd6a
14. hebasto merged this on Jun 12, 2022
15. hebasto closed this on Jun 12, 2022

    ---

16. hebasto deleted the branch on Jun 12, 2022
17. sidhujag referenced this in commit b9797c7811 on Jun 13, 2022
18. bitcoin-core locked this on Jun 12, 2023

Contributors
hebasto kristapsk furszy shaavan w0xlt

Labels
Refactoring Wallet