wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired` #609

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:220529-expired changing 2 files +1 −6

hebasto commented at 4:06 PM on May 29, 2022: member

The PaymentRequestExpired value in the WalletModel::StatusCode enumeration has been unused since bitcoin/bitcoin#17165.
qt, wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired`
Also dead code has been removed.
151009cf76
hebasto added the label Refactoring on May 29, 2022
hebasto added the label Wallet on May 29, 2022
hebasto renamed this:
~~qt, wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired`~~
wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired`
on May 29, 2022
furszy approved
furszy commented at 6:40 PM on May 29, 2022: contributor

ACK 151009cf, no usage for it.
kristapsk approved
kristapsk commented at 6:42 PM on May 29, 2022: contributor

cr ACK 151009cf76f3f1adc17630d5370bf019be127373, checked that PaymentRequestExpired is not referenced anywhere else.
hebasto merged this on May 30, 2022
hebasto closed this on May 30, 2022
hebasto deleted the branch on May 30, 2022

in src/qt/sendcoinsdialog.cpp:761 in 151009cf76

 756 | @@ -757,10 +757,6 @@ void SendCoinsDialog::processSendCoinsReturn(const WalletModel::SendCoinsReturn
 757 |      case WalletModel::AbsurdFee:
 758 |          msgParams.first = tr("A fee higher than %1 is considered an absurdly high fee.").arg(BitcoinUnits::formatWithUnit(model->getOptionsModel()->getDisplayUnit(), model->wallet().getDefaultMaxTxFee()));
 759 |          break;
 760 | -    case WalletModel::PaymentRequestExpired:
 761 | -        msgParams.first = tr("Payment request expired.");

flack commented at 7:56 PM on May 30, 2022:

Should the corresponding entries from the locae files also be removed, or is that done in Transifex somehow?

hebasto commented at 8:01 PM on May 30, 2022:

That is responsibility of the translation process.

sidhujag referenced this in commit 8a6fff0430 on May 31, 2022
jarolrod commented at 8:14 PM on June 5, 2022: member

post merge ACK https://github.com/bitcoin-core/gui/commit/151009cf76f3f1adc17630d5370bf019be127373
bitcoin-core locked this on Jun 5, 2023

Contributors

Labels