Remove unnecessary wallet includes from rpcconsole.cpp #613

pull laanwj wants to merge 1 commits into bitcoin-core:master from laanwj:2022-06-qtconsole-includes changing 1 files +0 −8
  1. laanwj commented at 4:18 pm on June 2, 2022: member
    Fixes bitcoin/bitcoin#25266
  2. qt: Remove unnecessary wallet includes from rpcconsole.cpp 0994273649
  3. laanwj added the label Wallet on Jun 2, 2022
  4. MarcoFalke commented at 4:28 pm on June 2, 2022: contributor

    cr ACK 09942736495502cedcef4b097dde6abd9327fbdb

    Should be correct if it compiles?

  5. laanwj commented at 4:37 pm on June 2, 2022: member
    I think so! I also did a cursory check for direct use of wallet classes but couldn’t find any. Everything goes through WalletModel etc.
  6. hebasto approved
  7. hebasto commented at 5:04 pm on June 2, 2022: member

    ACK 09942736495502cedcef4b097dde6abd9327fbdb.

    It has become redundant since bitcoin-core/gui#118.

  8. hebasto renamed this:
    qt: Remove unnecessary wallet includes from rpcconsole.cpp
    Remove unnecessary wallet includes from rpcconsole.cpp
    on Jun 2, 2022
  9. hebasto merged this on Jun 2, 2022
  10. hebasto closed this on Jun 2, 2022

  11. sidhujag referenced this in commit f0e87778dc on Jun 3, 2022
  12. bitcoin-core locked this on Jun 5, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 00:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me