Fix translator comment for Restore Wallet `QInputDialog` #629

pull w0xlt wants to merge 1 commits into bitcoin-core:master from w0xlt:471-follow-up changing 1 files +6 −2
  1. w0xlt commented at 2:56 PM on July 11, 2022: contributor

    Fix translator comment for Restore Wallet QInputDialog, as suggested in #471 (review).

    This also changes the window title name from Restore Name to Restore Wallet as it seems clearer.

  2. hebasto added the label Translations on Jul 15, 2022
  3. hebasto renamed this:
    gui: Fix translator comment for Restore Wallet `QInputDialog`
    Fix translator comment for Restore Wallet `QInputDialog`
    on Jul 15, 2022
  4. in src/qt/bitcoingui.cpp:435 in d7207dff67 outdated 
     430 | @@ -431,7 +431,10 @@ void BitcoinGUI::createActions()
 431 |  
 432 |              bool wallet_name_ok;
 433 |              //: Title of the Restore Wallet input dialog (where the wallet name is entered)
 434 | -            QString wallet_name = QInputDialog::getText(this, tr("Restore Name"), tr("Wallet Name:"), QLineEdit::Normal, "", &wallet_name_ok);
 435 | +            QString title = tr("Restore Wallet");
    jarolrod commented at 12:48 AM on July 17, 2022:

    you're changing the window title name from Restore Name to Restore Wallet. If this is intended, please document in the PR description why you are doing this. The mentioned review comment doesn't suggest this.

    w0xlt commented at 8:29 PM on July 17, 2022:

    Done.

  5. shaavan approved
  6. shaavan commented at 12:46 PM on July 19, 2022: contributor

    <s>LGTM</s> ACK d7207dff67d42bc06a3ca6534fe510a4936bc439

    • The added translation comment clearly explains the purpose of the text for which it is added.

    A small nit: I would suggest mentioning the title's renaming in the commit message as well.

    Edit: Address this comment. Thanks for notifying @hebasto!

  7. hebasto commented at 12:48 PM on July 19, 2022: member

    @shaavan

    LGTM d7207df

    "LGTM" cannot be parsed by the merging script.

  8. in src/qt/bitcoingui.cpp:435 in d7207dff67 outdated 
     430 | @@ -431,7 +431,10 @@ void BitcoinGUI::createActions()
 431 |  
 432 |              bool wallet_name_ok;
 433 |              //: Title of the Restore Wallet input dialog (where the wallet name is entered)
 434 | -            QString wallet_name = QInputDialog::getText(this, tr("Restore Name"), tr("Wallet Name:"), QLineEdit::Normal, "", &wallet_name_ok);
 435 | +            QString title = tr("Restore Wallet");
 436 | +            //: Label of the Restore Wallet input dialog (where the wallet name is entered)
    hebasto commented at 1:15 PM on July 19, 2022:

    For the consistency, do you mind adding a full stop to the end of the translator comments?

    (here and above)

  9. hebasto approved
  10. hebasto commented at 1:16 PM on July 19, 2022: member

    ACK d7207dff67d42bc06a3ca6534fe510a4936bc439, verified using make -C src translate.

  11. w0xlt force-pushed on Jul 21, 2022
  12. w0xlt commented at 2:41 AM on July 21, 2022: contributor

    #629 (review) and #629#pullrequestreview-1043371169 were addressed in https://github.com/bitcoin-core/gui/pull/629/commits/643e27e80310528db367eb514e1bee3b3332facd.

  13. jarolrod commented at 5:24 AM on July 21, 2022: member

    translator comments look good enough to me, maybe could do the following if you believe it's an improvement?

    --- a/src/qt/bitcoingui.cpp
+++ b/src/qt/bitcoingui.cpp
@@ -430,9 +430,10 @@ void BitcoinGUI::createActions()
             if (backup_file.isEmpty()) return;
 
             bool wallet_name_ok;
-            //: Title of the Restore Wallet input dialog (where the wallet name is entered).
+            /*: Title of pop-up window shown when the user is attempting to
+                restore a wallet. */
             QString title = tr("Restore Wallet");
-            //: Label of the Restore Wallet input dialog (where the wallet name is entered).
+            //: Label of the input field where the name of the wallet is entered.
             QString label = tr("Wallet Name");
             QString wallet_name = QInputDialog::getText(this, title, label, QLineEdit::Normal, "", &wallet_name_ok);
             if (!wallet_name_ok || wallet_name.isEmpty()) return;
  14. gui: Fix translator comment for Restore Wallet QInputDialog
    This also changes the window title name
from `Restore Name` to `Restore Wallet`.
    9d9a098530
  15. w0xlt force-pushed on Jul 23, 2022
  16. w0xlt commented at 2:27 AM on July 23, 2022: contributor

    #629#pullrequestreview-1045949325 addressed in https://github.com/bitcoin-core/gui/pull/629/commits/9d9a098530df9986039f64b2810b6375b715f196

  17. shaavan approved
  18. shaavan commented at 7:39 AM on July 23, 2022: contributor

    reACK 9d9a098530df9986039f64b2810b6375b715f196

    Changes since my last review:

    • The translator's comments have been updated.

    I feel the updated translator comments are an improvement and better clarify the purpose of the title and label Qstrings.

  19. hebasto merged this on Jul 23, 2022
  20. hebasto closed this on Jul 23, 2022
  21. w0xlt deleted the branch on Jul 24, 2022
  22. sidhujag referenced this in commit 760faf7f67 on Jul 24, 2022
  23. hebasto referenced this in commit bc29c4d4a5 on Sep 14, 2022
  24. sidhujag referenced this in commit cbbe8d7930 on Sep 14, 2022
  25. bitcoin-core locked this on Jul 24, 2023
Contributors
w0xltjarolrodshaavanhebasto
Labels
Translations
Linked (view graph)
#471 Add Wallet Restore in the GUI
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-27 03:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me