Added Tor icons to repo #67

pull Bosch-0 wants to merge 1 commits into bitcoin-core:master from Bosch-0:add-tor-icons changing 6 files +13 −0
  1. Bosch-0 commented at 10:39 AM on August 20, 2020: none

    Added the below icons to the repo which can be used for Tor network connectivity indicators #58.

    From previous discussion on issue.

    At some stage it would be nice to have some colored icons, but whilst the others are still in a black and white I think its important to stick with this style for now to keep consistency. I followed the same style that the connect icons use...

    Link to the figma file where I did the icon designs > https://www.figma.com/file/FJ02rY3m8V9ZCDvoXjW39W/Bitcoin-Core?node-id=486%3A312

    In order: Not connected -> connecting -> connected.

    image

    Here is some examples of how they could be shown

    image

    image

    image

  2. added tor icons 0668bcff27
  3. hebasto commented at 10:41 AM on August 20, 2020: member

    Concept ACK

  4. MarcoFalke commented at 3:45 PM on August 20, 2020: contributor

    What is the point of adding the icons if they are not shown in the gui?

  5. hebasto commented at 3:48 PM on August 20, 2020: member

    What is the point of adding the icons if they are not shown in the gui?

    I'll take care about it :)

  6. MarcoFalke commented at 3:53 PM on August 20, 2020: contributor

    Please add source/license to new files (contrib/debian/copyright) and optimize the png versions: https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimize-pngs.py

  7. jonatack commented at 4:38 PM on August 20, 2020: contributor

    Concept ACK

    (make sure it renders to look more like an onion than, say, a bomb ;)

  8. Bosch-0 commented at 7:26 PM on August 20, 2020: none

    What is the point of adding the icons if they are not shown in the gui?

    They will be soon as hebasto said. We have been discussing the implementation over at the bitcoin design slack.

    Though yes I guess I could have just passed the icons onto hebasto and he do a PR implementing them into the GUI but I figured some feedback on the design was important.

  9. Bosch-0 commented at 7:28 PM on August 20, 2020: none

    Concept ACK

    (make sure it renders to look more like an onion than, say, a bomb ;)

    There is both png and svg versions to play around with so the implementation can be a little flexible (using the svg's over pngs).

  10. jonasschnelli commented at 7:34 PM on August 20, 2020: contributor

    Concept ACK though I would prefer a simpler, less fine-grained icon.

  11. fanquake commented at 4:15 AM on August 21, 2020: member

    What is the point of adding the icons if they are not shown in the gui?

    I agree. These should be merged when they are being used; I don't think there's any need for us to start pulling in unused assets/imagery. If people are looking for feedback on designs, opening new issues in this repo or commenting in the existing threads is the way to go (I can see that was done in #58).

  12. Bosch-0 closed this on Sep 8, 2020

  13. Bosch-0 deleted the branch on Dec 3, 2020
  14. bitcoin-core locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-25 01:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me