doc: Fix comment about how wallet txs are sorted #705

pull john-moffett wants to merge 1 commits into bitcoin-core:master from john-moffett:2023_01_FixIncorrectCommentTTM changing 1 files +1 −4
  1. john-moffett commented at 3:15 pm on January 27, 2023: contributor

    The wallet transactions in the node are not sorted by txid (or any hash) since https://github.com/bitcoin/bitcoin/pull/24699.

    This is how they’re stored in memory now:

    https://github.com/bitcoin-core/gui/blob/835212cd1d8f8fc7f19775f5ff8cc21c099122b2/src/wallet/wallet.h#L397-L399

  2. Fix comment about how wallet txs are sorted
    The wallet transactions in the node are not sorted
    by hash. Also make comment Doxygen compatible.
    c497a198db
  3. DrahtBot commented at 3:15 pm on January 27, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK achow101, jarolrod

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. jarolrod added the label Doc on Jan 27, 2023
  5. hebasto added the label Wallet on Feb 2, 2023
  6. hebasto commented at 11:55 am on February 2, 2023: member
  7. achow101 commented at 11:20 pm on February 2, 2023: member
    ACK c497a198db6f417d2612078a9fbc101e259fab33
  8. jarolrod approved
  9. jarolrod commented at 2:19 am on February 3, 2023: member
    ACK c497a198db6f417d2612078a9fbc101e259fab33
  10. hebasto merged this on Feb 3, 2023
  11. hebasto closed this on Feb 3, 2023

  12. sidhujag referenced this in commit c665392cad on Feb 3, 2023
  13. bitcoin-core locked this on Feb 3, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-23 00:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me