Discussion in https://github.com/bitcoin/bitcoin/pull/16720 seems to point to this being no-longer needed after qt 5.6+. We now require 5.11.x+.
Drop macOS ForceActivation workaround #744
pull fanquake wants to merge 1 commits into bitcoin-core:master from fanquake:drop_macos_force_workaround changing 2 files +0 −15-
fanquake commented at 6:23 PM on June 30, 2023: member
-
362e989373
gui: drop macOS ForceActivation workaround
Discussion in #16720 seems to point to this being no-longer needed after qt 5.6+. We now required 5.11.x+.
-
DrahtBot commented at 6:23 PM on June 30, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers Concept ACK hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- hebasto renamed this:
gui: drop macOS ForceActivation workaround
Drop macOS ForceActivation workaround
on Jul 3, 2023 -
-
hebasto commented at 12:37 PM on July 3, 2023: member
I think we can drop
-DOBJC_OLD_DISPATCH_PROTOTYPES=0now. At least, the code compiles for me natively on macOS Ventura (arm64) and when cross-building on Ubuntu 23.04. - hebasto added the label macOS on Jul 3, 2023
-
Sjors commented at 2:36 PM on July 3, 2023: member
Tested 362e98937356a74a5b70d65348957edf05b1138a but it seems the workaround is still needed.
This was introduced in https://github.com/bitcoin/bitcoin/pull/14123 as a fix to https://github.com/bitcoin/bitcoin/issues/13829.
With this PR, built on macOS 13.4.1 (Intel) with qt@5/5.15.10 via Homebrew, when I use
⌘ + Hto hide the window, and then e.g. click on "Receive" in the dock, the window doesn't appear. Without this PR the window does appear. - fanquake closed this on Jul 27, 2023
- bitcoin-core locked this on Jul 26, 2024
