When you have a v2 connection, there is always a session ID.
the if any is a leftover from #754, where the session ID property initially would always be displayed (transport v1 and v2). So the session ID could be empty when you have a v1 connection.
As now the Session ID property only is displayed for v2 connection, there will always be a session ID.
master
PR
Session ID not shown when transport v1
remove "if any"
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | kristapsk, vostrnad, jarolrod, pablomartin4btc, hebasto |
| Concept ACK | BrandonOdiwuor, hernanmarino |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Concept ACK
nit: @MarnixCroes, maybe you can add the screenshot for transport v1 and session ID is empty/ not shown, if possible, even this PR doesn’t affect that logic.
Concept ACK
nit: @MarnixCroes, maybe you can add the screenshot for transport v1 and session ID is empty/ not shown, if possible, even this PR doesn’t affect that logic.
done
When you have a v2 connection, there is always a session ID.
What if the connection type is still DETECTING?
The code reference:https://github.com/bitcoin-core/gui/blob/6737331c4ccc6da578bb44c809cc4e18f017ba51/src/node/connection_types.h#L83-L88
When you have a v2 connection, there is always a session ID.
What if the connection type is still
DETECTING?The code reference:
then there is no session ID property as it is not a v2 peer (yet), right
tACK 3bf00e13609eefa6ddb11353519bb1aec2342513
v2 transport with Session ID field displayed:v1 transport without it:
